Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1290573004: Use RtcpPacket to send REMB in RtcpSender (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -40 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +8 lines, -40 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sprang_webrtc
5 years, 4 months ago (2015-08-13 12:28:52 UTC) #2
åsapersson
lgtm
5 years, 4 months ago (2015-08-17 08:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290573004/1
5 years, 4 months ago (2015-08-17 08:26:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-17 11:00:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290573004/1
5 years, 4 months ago (2015-08-18 08:27:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/375)
5 years, 4 months ago (2015-08-18 08:28:39 UTC) #11
sprang_webrtc
Committed patchset #1 (id:1) manually as 35ab4baa20a730de71b390008900a16563cbbe8e (presubmit successful).
5 years, 4 months ago (2015-08-18 09:54:25 UTC) #12
sprang_webrtc
5 years, 4 months ago (2015-08-18 11:37:20 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1300863002/ by sprang@webrtc.org.

The reason for reverting is: A few bots started failing rtc_unittests after this
was commited. Ex
https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5048
.

Powered by Google App Engine
This is Rietveld 408576698