Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1290233003: For TestResolverShutdown, use address that can't be resolved. (Closed)

Created:
5 years, 4 months ago by Taylor Brandstetter
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

For TestResolverShutdown, use address that can't be resolved. This test only currently works because stun.l.google.com has an IPv4 address and the TURN port is created with an IPv6 address. But the test would start failing if/when it starts providing an IPv6 address. Which may already be happening, as indicated by a recent test failure. Committed: https://crrev.com/71cfe690b709d47432e0bcd12add737e2ed94fe6 Cr-Commit-Position: refs/heads/master@{#9841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/p2p/base/turnport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Taylor Brandstetter
Hi Peter; one more small thing to review. I'm hoping it will fix this failure: ...
5 years, 4 months ago (2015-08-13 23:25:49 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-02 00:46:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290233003/1
5 years, 3 months ago (2015-09-02 01:19:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 02:01:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 02:01:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71cfe690b709d47432e0bcd12add737e2ed94fe6
Cr-Commit-Position: refs/heads/master@{#9841}

Powered by Google App Engine
This is Rietveld 408576698