|
|
Revert "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied."
This reverts commit 0a2955f227666efd87b2a303a69c083ef801c528.
Revert "In the past, P2PPortAllocator.enable_multiple_routes is the indicator whether we should bind to the any address. It's easy to translate that into a port allocator flag in P2PPortAllocator's ctor. Going forward, we have to depend on an asynchronous permission check to determine whether gathering local address is allowed or not, hence the current way of passing it through constructor approach won't work any more. The asynchronous check will trigger SignalNetowrksChanged so we could only check that inside DoAllocate."
This reverts commit ba9ab4cd8d2e8fbc068dc36b5e6f6331d7deeccf.
TBR=pthatcher@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/370c8848ad38d54457a960e0ebe94f8adf370e23
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+51 lines, -200 lines) |
Patch |
 |
M |
talk/app/webrtc/peerconnectioninterface.h
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
talk/app/webrtc/webrtcsession.cc
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
webrtc/base/fakenetwork.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/base/ipaddress.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/base/ipaddress.cc
|
View
|
|
1 chunk |
+1 line, -10 lines |
0 comments
|
Download
|
|
M |
webrtc/base/network.h
|
View
|
|
4 chunks |
+1 line, -22 lines |
0 comments
|
Download
|
|
M |
webrtc/base/network.cc
|
View
|
|
2 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
|
M |
webrtc/base/network_unittest.cc
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
|
M |
webrtc/p2p/base/port_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/p2p/base/portallocator.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
webrtc/p2p/base/stunport.h
|
View
|
|
6 chunks |
+7 lines, -17 lines |
0 comments
|
Download
|
|
M |
webrtc/p2p/base/stunport.cc
|
View
|
|
4 chunks |
+7 lines, -20 lines |
0 comments
|
Download
|
|
M |
webrtc/p2p/base/stunport_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/p2p/base/turnport_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
webrtc/p2p/client/basicportallocator.cc
|
View
|
|
3 chunks |
+12 lines, -25 lines |
0 comments
|
Download
|
|
M |
webrtc/p2p/client/fakeportallocator.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
webrtc/p2p/client/portallocator_unittest.cc
|
View
|
|
8 chunks |
+17 lines, -71 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|
Chromium Code Reviews
Issue
1288843003:
Revert "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied… (Closed)
