Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1288453003: Print some output in long perf tests, to keep them alive (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Print some output in long perf tests, to keep them alive At least Android try bots seem to have a timeout that will forcibly shut down the executable if no output has been observed for 60s. Since full stack test typically run for 60s we need to output give some to avoid racy shutdown. BUG=chromium:513170 R=pbos@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2c27430545098f17bc716335a8677a9d21cecac0

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't just print at the first timeout... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M webrtc/video/full_stack.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sprang_webrtc
5 years, 4 months ago (2015-08-11 08:03:02 UTC) #2
sprang_webrtc
Reassigning to pbos
5 years, 3 months ago (2015-08-31 10:14:05 UTC) #4
pbos-webrtc
https://codereview.webrtc.org/1288453003/diff/1/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1288453003/diff/1/webrtc/video/full_stack.cc#newcode238 webrtc/video/full_stack.cc:238: "Uh, I'm-I'm not quite dead, sir.", Wat? Where should ...
5 years, 3 months ago (2015-08-31 12:30:28 UTC) #5
sprang_webrtc
https://codereview.webrtc.org/1288453003/diff/1/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1288453003/diff/1/webrtc/video/full_stack.cc#newcode238 webrtc/video/full_stack.cc:238: "Uh, I'm-I'm not quite dead, sir.", On 2015/08/31 12:30:27, ...
5 years, 3 months ago (2015-08-31 13:05:17 UTC) #6
pbos-webrtc
lgtm, good lines
5 years, 3 months ago (2015-08-31 13:06:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288453003/20001
5 years, 3 months ago (2015-08-31 13:08:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years, 3 months ago (2015-08-31 15:08:24 UTC) #11
sprang_webrtc
5 years, 3 months ago (2015-08-31 15:21:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c27430545098f17bc716335a8677a9d21cecac0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698