Update SendTimeHistory to store complete PacketInfo, not just send time

webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 32 matching lines @@
 
 int FullBweSender::GetFeedbackIntervalMs() const {
   return kFeedbackIntervalMs;
 }
 
 void FullBweSender::GiveFeedback(const FeedbackPacket& feedback) {
   const SendSideBweFeedback& fb =
       static_cast<const SendSideBweFeedback&>(feedback);
   if (fb.packet_feedback_vector().empty())
     return;
   // TODO(sprang): Unconstify PacketInfo so we don't need temp copy?

[stefan-webrtc, 2015/09/03 11:30:33]

Has this been done already? I don't see any consts.

[sprang_webrtc, 2015/09/03 13:24:09]

This comment doesn't make sense any more. Removing it.

   std::vector<PacketInfo> packet_feedback_vector(fb.packet_feedback_vector());
-  for (PacketInfo& packet : packet_feedback_vector) {
-    if (!send_time_history_.GetSendTime(packet.sequence_number,
-                                        &packet.send_time_ms, true)) {
+  for (PacketInfo& packet_info : packet_feedback_vector) {
+    if (!send_time_history_.Populate(&packet_info, true)) {
       LOG(LS_WARNING) << "Ack arrived too late.";
     }
   }
 
   int64_t rtt_ms =
       clock_->TimeInMilliseconds() - feedback.latest_send_time_ms();
   rbe_->OnRttUpdate(rtt_ms, rtt_ms);
   BWE_TEST_LOGGING_PLOT(1, "RTT", clock_->TimeInMilliseconds(), rtt_ms);
 
   rbe_->IncomingPacketFeedbackVector(packet_feedback_vector);
@@ skipping 20 matching lines @@
   } else {
     last_acked_seq_num_ = packet_feedback_vector.back().sequence_number;
     has_received_ack_ = true;
   }
 }
 
 void FullBweSender::OnPacketsSent(const Packets& packets) {
   for (Packet* packet : packets) {
     if (packet->GetPacketType() == Packet::kMedia) {
       MediaPacket* media_packet = static_cast<MediaPacket*>(packet);
-      send_time_history_.AddAndRemoveOldSendTimes(
-          media_packet->header().sequenceNumber,
-          media_packet->GetAbsSendTimeInMs());
+      PacketInfo info(0, media_packet->sender_timestamp_ms(),
+                      media_packet->header().sequenceNumber,
+                      media_packet->payload_size(), packet->was_paced());
+      send_time_history_.AddAndRemoveOld(info);
     }
   }
 }
 
 void FullBweSender::OnReceiveBitrateChanged(
     const std::vector<unsigned int>& ssrcs,
     unsigned int bitrate) {
   feedback_observer_->OnReceivedEstimatedBitrate(bitrate);
 }
 
@@ skipping 32 matching lines @@
       packet_feedback_vector_.back().arrival_time_ms;
   FeedbackPacket* fb = new SendSideBweFeedback(
       flow_id_, now_ms * 1000, corrected_send_time_ms, packet_feedback_vector_);
   packet_feedback_vector_.clear();
   return fb;
 }
 
 }  // namespace bwe
 }  // namespace testing
 }  // namespace webrtc