Adding audio RepetitionDetector in AudioProcessingModule.

webrtc/modules/audio_processing/audio_processing_impl.cc

Index: webrtc/modules/audio_processing/audio_processing_impl.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_impl.cc b/webrtc/modules/audio_processing/audio_processing_impl.cc
index bbfb771182cc7196f0e8e0ca9fb63860617d6b8f..c0ed806d98d892ffebca4c68ef26a9601fb08d80 100644
--- a/webrtc/modules/audio_processing/audio_processing_impl.cc
+++ b/webrtc/modules/audio_processing/audio_processing_impl.cc
@@ -32,6 +32,7 @@ extern "C" {
 #include "webrtc/modules/audio_processing/level_estimator_impl.h"
 #include "webrtc/modules/audio_processing/noise_suppression_impl.h"
 #include "webrtc/modules/audio_processing/processing_component.h"
+#include "webrtc/modules/audio_processing/repetition_detector.h"
 #include "webrtc/modules/audio_processing/transient/transient_suppressor.h"
 #include "webrtc/modules/audio_processing/voice_detection_impl.h"
 #include "webrtc/modules/interface/module_common_types.h"
@@ -210,7 +211,8 @@ AudioProcessingImpl::AudioProcessingImpl(const Config& config,
 #endif
       beamformer_enabled_(config.Get<Beamforming>().enabled),
       beamformer_(beamformer),
-      array_geometry_(config.Get<Beamforming>().array_geometry) {
+      array_geometry_(config.Get<Beamforming>().array_geometry),
+      repetition_detector_(new RepetitionDetector()) {

[Andrew MacDonald, 2015/08/11 18:53:05]

We usually lazily initialize components, so you would create this only if
requested.

[minyue-webrtc, 2015/08/12 11:32:13]

Acknowledged.

   echo_cancellation_ = new EchoCancellationImpl(this, crit_);
   component_list_.push_back(echo_cancellation_);
 
@@ -569,6 +571,9 @@ int AudioProcessingImpl::ProcessStream(AudioFrame* frame) {
     return kUnsupportedComponentError;
   }
 
+  repetition_detector_->Detect(frame->data_, frame->samples_per_channel_,

[Andrew MacDonald, 2015/08/11 20:50:42]

All processing/analysis should be done in ProcessStreamLocked.

[minyue-webrtc, 2015/08/12 11:32:13]

We'd better access raw data (frame), ProcessStreamLocked() does not have access
to it. What would you suggest?

[Andrew MacDonald, 2015/08/12 20:25:32]

See how the other components access the data (through AudioBuffer). You're right
that resampling could occur before you get access to the audio, but that could
have happened outside APM already anyway. I'd attempt to make your algorithm
robust to minor variations.

[peah-webrtc, 2015/08/12 21:05:16]

That makes sense. I today looked into a recording where the matching was not
100% identical sample wise but where the difference was tiny and it was clearly
repeated audio.

+                               frame->num_channels_);
+
   // TODO(ajm): The input and output rates and channels are currently
   // constrained to be identical in the int16 interface.
   ProcessingConfig processing_config = api_format_;
@@ -623,6 +628,7 @@ int AudioProcessingImpl::ProcessStreamLocked() {
   MaybeUpdateHistograms();
 
   AudioBuffer* ca = capture_audio_.get();  // For brevity.
+

[hlundin-webrtc, 2015/08/12 14:12:04]

Why new line?

   if (use_new_agc_ && gain_control_->is_enabled()) {
     agc_manager_->AnalyzePreProcess(ca->channels()[0], ca->num_channels(),
                                     fwd_proc_format_.num_frames());