Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1287333005: NetEq: Implement two UMA stats for delay adaptation. (Closed)

Created:
5 years, 4 months ago by hlundin-webrtc
Modified:
5 years, 4 months ago
Reviewers:
ivoc, *minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@neteq-metrics
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Implement two UMA stats for delay adaptation. This CL adds calculation and logging of average excess buffer delay and number of delayed packet outage events per minute. The first is the average of time spent in the packet buffer for all packets. The average is calculated for intervals of one minute, and the result is logged to the UMA stat WebRTC.Audio.AverageExcessBufferDelayMs. The second is a counter of delayed packet outage events that is restarted every minute, and the result is logged to the UMA stat WebRTC.Audio.DelayedPacketOutageEventsPerMinute. For a description of delayed packet outages, see previous CL implementing a duration log for these events. BUG=webrtc:4915, chromium:488124 R=minyue@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/1f4ffe02fb565cc29e4d5c1d1a3423e9eff9c4ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -2 lines) Patch
M webrtc/modules/audio_coding/neteq/statistics_calculator.h View 4 chunks +57 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/statistics_calculator.cc View 4 chunks +91 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
Please, review this change. It replaces https://codereview.webrtc.org/1292423003/ and https://codereview.webrtc.org/1284303003/ which will both be dropped. Thanks! ...
5 years, 4 months ago (2015-08-18 13:30:41 UTC) #3
minyue-webrtc
lgtm clean and neat!
5 years, 4 months ago (2015-08-18 14:06:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287333005/1
5 years, 4 months ago (2015-08-19 07:46:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8908)
5 years, 4 months ago (2015-08-19 08:02:03 UTC) #8
hlundin-webrtc
5 years, 4 months ago (2015-08-19 08:47:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f4ffe02fb565cc29e4d5c1d1a3423e9eff9c4ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698