Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1287203007: Move scoped_ptr.h to rtc_base_approved. (Closed)

Created:
5 years, 4 months ago by tommi
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move scoped_ptr.h to rtc_base_approved. This is more a formality than anything since scoped_ptr.h is already being included from rtc_base_approved code. BUG= R=magjed@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c844ca425e8c09bd9545e3956cb85339b50a48ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/base/base.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287203007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287203007/1
5 years, 4 months ago (2015-08-18 13:02:17 UTC) #2
tommi
5 years, 4 months ago (2015-08-18 13:02:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux/builds/9049)
5 years, 4 months ago (2015-08-18 13:12:10 UTC) #6
magjed_webrtc
lgtm
5 years, 4 months ago (2015-08-19 08:30:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287203007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287203007/1
5 years, 4 months ago (2015-08-19 08:31:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8910)
5 years, 4 months ago (2015-08-19 08:46:53 UTC) #11
tommi
5 years, 4 months ago (2015-08-19 08:51:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c844ca425e8c09bd9545e3956cb85339b50a48ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698