Fixing problems with RTP extension ID conflict resolution

Fixing problems with RTP extension ID conflict resolution

If the same extension URI is used for both audio and video (such as
abs-send-time), we should be able to re-use the same ID. A conflict
only exists if two different URIs are attempting to use the same ID.

Committed: https://crrev.com/a5b273a635b9876f88430934de19a883a1fb5728
Cr-Commit-Position: refs/heads/master@{#9749}

[Taylor Brandstetter, 2015-08-12 22:45:48]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2015-08-12 22:45:49]

Part 1 of the video flashing bug fix

[pthatcher1, 2015-08-18 20:33:12]

lgtm, with nits

https://codereview.webrtc.org/1286273003/diff/20001/talk/session/media/medias...
File talk/session/media/mediasession.cc (right):

https://codereview.webrtc.org/1286273003/diff/20001/talk/session/media/medias...
talk/session/media/mediasession.cc:935: for (auto reference_extension :
reference_extensions) {
Can't it be "const auto&" instead of auto?

[Taylor Brandstetter, 2015-08-18 20:55:06]

https://codereview.webrtc.org/1286273003/diff/20001/talk/session/media/medias...
File talk/session/media/mediasession.cc (right):

https://codereview.webrtc.org/1286273003/diff/20001/talk/session/media/medias...
talk/session/media/mediasession.cc:935: for (auto reference_extension :
reference_extensions) {
On 2015/08/18 20:33:12, pthatcher1 wrote:
> Can't it be "const auto&" instead of auto?

No, because FindAndSetIdUsed modifies the id, and we don't want to modify the id
of our stored reference extensions.

[pthatcher1, 2015-08-18 20:59:35]

lgtm

[Taylor Brandstetter, 2015-08-20 23:12:22]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2015-08-20 23:12:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286273003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286273003/20001

[commit-bot: I haz the power, 2015-08-21 00:30:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-21 00:30:25]

Patchset 2 (id:??) landed as
https://crrev.com/a5b273a635b9876f88430934de19a883a1fb5728
Cr-Commit-Position: refs/heads/master@{#9749}