Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284383005: Delete dummy dtlsidentityservice.[cc,h] files. (Closed)

Created:
5 years, 4 months ago by hbos
Modified:
5 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete dummy dtlsidentityservice.[cc,h] files. BUG=webrtc:4899 Committed: https://crrev.com/4c530dccb33be5a3089a47efd280b1585ec7afd2 Cr-Commit-Position: refs/heads/master@{#9711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
D talk/app/webrtc/dtlsidentityservice.h View 1 chunk +0 lines, -28 lines 0 comments Download
D talk/app/webrtc/dtlsidentityservice.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hbos
PTAL tommi whoop whoop
5 years, 4 months ago (2015-08-14 09:23:35 UTC) #2
hbos
I'll commit with CQ so the bots will get run.
5 years, 4 months ago (2015-08-14 09:29:18 UTC) #3
tommi
lgtm. description nit: s/Deleted/Delete (what the cl does, not what it did)
5 years, 4 months ago (2015-08-14 09:46:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284383005/1
5 years, 4 months ago (2015-08-14 10:09:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 10:52:42 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 10:52:54 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4c530dccb33be5a3089a47efd280b1585ec7afd2
Cr-Commit-Position: refs/heads/master@{#9711}

Powered by Google App Engine
This is Rietveld 408576698