Move the concept of multiple route into Network

webrtc/base/network.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 38 matching lines @@
 // length of that prefix.
 std::string MakeNetworkKey(const std::string& name, const IPAddress& prefix,
                            int prefix_length);
 
 // Generic network manager interface. It provides list of local
 // networks.
 class NetworkManager {
  public:
   typedef std::vector<Network*> NetworkList;
 
+  // This enum indicates the state of GetNetworks.
+  enum NetworkPermissionState {
+    STATE_UNKNOWN,  // SignalNetworksChanged is not fired yet.
+    STATE_ALLOWED,  // Adapter enumeration is allowed. Getting 0 network from
+                    // GetNetworks means that there is no network available.
+    STATE_BLOCKED   // Adapter enumeration is disabled. GetAnyAddressNetworks()
+                    // should be used instead.
+  };
+
   NetworkManager();
   virtual ~NetworkManager();
 
   // Called when network list is updated.
   sigslot::signal0<> SignalNetworksChanged;
 
   // Indicates a failure when getting list of network interfaces.
   sigslot::signal0<> SignalError;
 
   // Start/Stop monitoring of network interfaces
   // list. SignalNetworksChanged or SignalError is emitted immediately
   // after StartUpdating() is called. After that SignalNetworksChanged
   // is emitted whenever list of networks changes.
   virtual void StartUpdating() = 0;
   virtual void StopUpdating() = 0;
 
   // Returns the current list of networks available on this machine.
-  // UpdateNetworks() must be called before this method is called.
+  // StartUpdating() must be called before this method is called.
   // It makes sure that repeated calls return the same object for a
   // given network, so that quality is tracked appropriately. Does not
   // include ignored networks.
   virtual void GetNetworks(NetworkList* networks) const = 0;
 
+  // return the current permission state of GetNetworks()
+  NetworkPermissionState network_permission_state() const {
+    return network_permission_state_;
+  }
+
   // "AnyAddressNetwork" is a network which only contains single "any address"
   // IP address.  (i.e. INADDR_ANY for IPv4 or in6addr_any for IPv6). This is
   // useful as binding to such interfaces allow default routing behavior like
   // http traffic.
   // TODO(guoweis): remove this body when chromium implements this.
   virtual void GetAnyAddressNetworks(NetworkList* networks) {}
 
   // Dumps a list of networks available to LS_INFO.
   virtual void DumpNetworks(bool include_ignored) {}
 
   struct Stats {
     int ipv4_network_count;
     int ipv6_network_count;
     Stats() {
       ipv4_network_count = 0;
       ipv6_network_count = 0;
     }
   };
+
+ protected:

[juberti1, 2015/08/14 20:58:39]

Can this go down into NetworkManagerBase? This class is more like an interface,
and not sure it should have data members.

Either way, protected member vars are discouraged. This var, wherever it lives,
should be updated by a setter.

+  NetworkPermissionState network_permission_state_ = STATE_UNKNOWN;
 };
 
 // Base class for NetworkManager implementations.
 class NetworkManagerBase : public NetworkManager {
  public:
   NetworkManagerBase();
   ~NetworkManagerBase() override;
 
   void GetNetworks(std::vector<Network*>* networks) const override;
   void GetAnyAddressNetworks(NetworkList* networks) override;
@@ skipping 191 matching lines @@
   bool ignored_;
   AdapterType type_;
   int preference_;
 
   friend class NetworkManager;
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_NETWORK_H_