Move the concept of multiple route into Network

webrtc/p2p/client/basicportallocator.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 289 matching lines @@
 // For each network, see if we have a sequence that covers it already.  If not,
 // create a new sequence to create the appropriate ports.
 void BasicPortAllocatorSession::DoAllocate() {
   bool done_signal_needed = false;
   std::vector<rtc::Network*> networks;
 
   // If the adapter enumeration is disabled, we'll just bind to any address
   // instead of specific NIC. This is to ensure the same routing for http
   // traffic by OS is also used here to avoid any local or public IP leakage
   // during stun process.
+  if (allocator_->network_manager()->adapter_enumeration_disabled()) {

[juberti1, 2015/08/13 20:45:58]

It seems odd to set a flag based on some other condition. I would suggest doing
this as 

if (flags() & PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION ||
   allocator_->network_manager()->IsAdapterEnumerationDisabled())

[guoweis_webrtc, 2015/08/13 20:54:14]

There are other places in the code which depends on this flag. If the pattern of
setting the flag inside the webrtc code base is discouraged, I'll modify these
other places as well.

[juberti1, 2015/08/13 22:10:11]

I see. In that case this seems like the best approach; just add a comment to say
that if the network manager has disabled enumeration, we just act as if the PA
flag has been set. Or would it be possible to remove the PA flag and just use
the NetworkManager setting?

+    set_flags(flags() | PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION);
+  }
+
   if (flags() & PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION) {
     allocator_->network_manager()->GetAnyAddressNetworks(&networks);
   } else {
     allocator_->network_manager()->GetNetworks(&networks);
   }
   if (networks.empty()) {
     LOG(LS_WARNING) << "Machine has no networks; no ports will be allocated";
     done_signal_needed = true;
   } else {
     for (uint32 i = 0; i < networks.size(); ++i) {
@@ skipping 799 matching lines @@
   ServerAddresses servers;
   for (size_t i = 0; i < relays.size(); ++i) {
     if (relays[i].type == turn_type && SupportsProtocol(relays[i], type)) {
       servers.insert(relays[i].ports.front().address);
     }
   }
   return servers;
 }
 
 }  // namespace cricket