Issue 1280573002: Suppress a race in libjingle_peerconnection_unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1280573002: Suppress a race in libjingle_peerconnection_unittest (Closed)

Created:
5 years, 4 months ago by hlundin-webrtc

Modified:
5 years, 4 months ago

Reviewers:
kjellander_webrtc, pbos-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, the sun

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Suppress a race in libjingle_peerconnection_unittest PeerConnectionInterfaceTest.GetStatsForSpecificTrack is sometimes failing on TSan. BUG=webrtc:4719 TBR=kjellander@webrtc.org Committed: https://crrev.com/2e1d8bb0fd9fd6c6dbb31251724bbcfa37780046 Cr-Commit-Position: refs/heads/master@{#9684}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webrtc/build/sanitizers/tsan_suppressions_webrtc.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280573002/1

5 years, 4 months ago (2015-08-06 09:24:05 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/2e1d8bb0fd9fd6c6dbb31251724bbcfa37780046 Cr-Commit-Position: refs/heads/master@{#9684}

5 years, 4 months ago (2015-08-06 11:34:48 UTC) #4

pbos-webrtc

5 years, 4 months ago (2015-08-24 09:51:38 UTC) #5

Message was sent while issue was closed.

On 2015/08/06 11:34:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/2e1d8bb0fd9fd6c6dbb31251724bbcfa37780046
> Cr-Commit-Position: refs/heads/master@{#9684}

lgtm, I believe BUG= should've included/been
https://code.google.com/p/webrtc/issues/detail?id=3682

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages