Fix distortions of remote stream with odd size dimensions

Fix distortions of remote stream with odd size dimensions

BUG=webrtc:4482
Committed: https://crrev.com/d941b7609c64516f1b93a0909a0bc23c10d26173
Cr-Commit-Position: refs/heads/master@{#9702}

[budnyjj, 2015-08-06 08:51:18]

budnyjj@gmail.com changed reviewers:
+ braveyao@webrtc.org, glaznev@webrtc.org

[AlexG, 2015-08-06 18:01:48]

glaznev@webrtc.org changed reviewers:
+ magjed@webrtc.org

[AlexG, 2015-08-06 18:04:12]

On 2015/08/06 08:52:24, budnyjj wrote:

Have you verified if using this alignment will not cause rendering performance
degradation especially for glTexImage2D calls? Did you still observe similar
average draw times printed in the log?

[AlexG, 2015-08-06 20:30:11]

On 2015/08/06 18:04:12, AlexG wrote:
> On 2015/08/06 08:52:24, budnyjj wrote:
> 
> Have you verified if using this alignment will not cause rendering performance
> degradation especially for glTexImage2D calls? Did you still observe similar
> average draw times printed in the log?

Or may be try to set unpack alignment to 1 only if video frame is yuv and its
width is odd? 
Not sure though if pixels storage mode can be updated dynamically.

[budnyjj, 2015-08-07 09:15:53]

On 2015/08/06 18:04:12, AlexG wrote:
> On 2015/08/06 08:52:24, budnyjj wrote:
> 
> Have you verified if using this alignment will not cause rendering performance
> degradation especially for glTexImage2D calls? Did you still observe similar
> average draw times printed in the log?

I've performed tests with AppRTCDemo, using 720p webcam on web side, and Nexus 5
with Android 4.4.3.
Here are the average values of the each ten VideoRendererGui.logStatistics
method invocations:

Default alignment (by 4 byte):
1. Draw time: 1626.4
   Copy time: 817.2

2. Draw time: 1758.9
   Copy time: 946.5

3. Draw time: 1576.18
   Copy time: 956.545

Per-byte alignment:
1. Draw time: 1685.75
   Copy time: 731.417

2. Draw time: 1673.2
   Copy time: 860

3. Draw time: 1745
   Copy time: 926.3

I think that these values are similar.

[AlexG, 2015-08-07 17:03:23]

On 2015/08/07 09:15:53, budnyjj wrote:
> On 2015/08/06 18:04:12, AlexG wrote:
> > On 2015/08/06 08:52:24, budnyjj wrote:
> > 
> > Have you verified if using this alignment will not cause rendering
performance
> > degradation especially for glTexImage2D calls? Did you still observe similar
> > average draw times printed in the log?
> 
> I've performed tests with AppRTCDemo, using 720p webcam on web side, and Nexus
5
> with Android 4.4.3.
> Here are the average values of the each ten VideoRendererGui.logStatistics
> method invocations:
> 
> Default alignment (by 4 byte):
> 1. Draw time: 1626.4
>    Copy time: 817.2
> 
> 2. Draw time: 1758.9
>    Copy time: 946.5
> 
> 3. Draw time: 1576.18
>    Copy time: 956.545
> 
> Per-byte alignment:
> 1. Draw time: 1685.75
>    Copy time: 731.417
> 
> 2. Draw time: 1673.2
>    Copy time: 860
> 
> 3. Draw time: 1745
>    Copy time: 926.3
> 
> I think that these values are similar.

Thanks!

lgtm

[braveyao1, 2015-08-12 02:42:52]

The CQ bit was checked by braveyao@webrtc.org

[commit-bot: I haz the power, 2015-08-12 02:43:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1280483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1280483003/20001

[commit-bot: I haz the power, 2015-08-12 03:29:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-12 03:29:11]

Patchset 2 (id:??) landed as
https://crrev.com/d941b7609c64516f1b93a0909a0bc23c10d26173
Cr-Commit-Position: refs/heads/master@{#9702}