Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1279543005: Add average rtt to CallStatsObserver and an average rtt histogram. (Closed)

Created:
5 years, 4 months ago by stefan-webrtc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson, mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add average rtt to CallStatsObserver and an average rtt histogram. TBR=mflodman@webrtc.org BUG=webrtc:4711, webrtc:4548 Committed: https://crrev.com/2328a94ec7ee545a26e8220c5ae157e1b3b5144f Cr-Commit-Position: refs/heads/master@{#9687}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added guards #

Messages

Total messages: 21 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279543005/1
5 years, 4 months ago (2015-08-07 08:56:39 UTC) #2
stefan-webrtc
5 years, 4 months ago (2015-08-07 08:56:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-07 09:50:50 UTC) #6
åsapersson
lgtm https://codereview.webrtc.org/1279543005/diff/1/webrtc/video_engine/vie_channel.h File webrtc/video_engine/vie_channel.h (right): https://codereview.webrtc.org/1279543005/diff/1/webrtc/video_engine/vie_channel.h#newcode486 webrtc/video_engine/vie_channel.h:486: int64_t time_of_first_rtt_ms_; guarded by crit_
5 years, 4 months ago (2015-08-07 10:15:57 UTC) #7
stefan-webrtc
https://codereview.webrtc.org/1279543005/diff/1/webrtc/video_engine/vie_channel.h File webrtc/video_engine/vie_channel.h (right): https://codereview.webrtc.org/1279543005/diff/1/webrtc/video_engine/vie_channel.h#newcode486 webrtc/video_engine/vie_channel.h:486: int64_t time_of_first_rtt_ms_; On 2015/08/07 10:15:57, asapersson wrote: > guarded ...
5 years, 4 months ago (2015-08-07 10:17:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279543005/20001
5 years, 4 months ago (2015-08-07 10:17:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/327)
5 years, 4 months ago (2015-08-07 10:19:48 UTC) #13
stefan-webrtc
Magnus, can you take a look after the fact on module_common_types.h?
5 years, 4 months ago (2015-08-07 11:26:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279543005/20001
5 years, 4 months ago (2015-08-07 11:26:54 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 11:27:55 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2328a94ec7ee545a26e8220c5ae157e1b3b5144f Cr-Commit-Position: refs/heads/master@{#9687}
5 years, 4 months ago (2015-08-07 11:28:06 UTC) #19
mflodman
module_common_types.h LGTM
5 years, 4 months ago (2015-08-11 13:45:41 UTC) #20
mflodman
5 years, 4 months ago (2015-08-14 08:05:02 UTC) #21
Message was sent while issue was closed. 
module_common_types.h LGTM

Powered by Google App Engine
This is Rietveld 408576698