Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1278383002: Remove avg encode time from CpuOveruseMetric struct and use value from OnEncodedFrame instead. (Closed)

Created:
5 years, 4 months ago by åsapersson
Modified:
5 years ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove avg encode time from CpuOveruseMetric struct and use value from OnEncodedFrame instead. BUG= Committed: https://crrev.com/1aa420b6aa70bd97cbe33e396e5dc0346aeb6415 Cr-Commit-Position: refs/heads/master@{#10911}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -67 lines) Patch
M webrtc/video/send_statistics_proxy.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 3 4 chunks +5 lines, -3 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 2 3 1 chunk +8 lines, -0 lines 1 comment Download
M webrtc/video_engine/overuse_frame_detector.h View 1 2 3 4 3 chunks +1 line, -7 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector.cc View 1 2 5 chunks +8 lines, -45 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector_unittest.cc View 1 2 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
åsapersson
5 years ago (2015-12-07 08:55:08 UTC) #6
pbos-webrtc
lgtm https://codereview.webrtc.org/1278383002/diff/120001/webrtc/video/send_statistics_proxy_unittest.cc File webrtc/video/send_statistics_proxy_unittest.cc (right): https://codereview.webrtc.org/1278383002/diff/120001/webrtc/video/send_statistics_proxy_unittest.cc#newcode296 webrtc/video/send_statistics_proxy_unittest.cc:296: EXPECT_EQ(kEncodeTimeMs, stats.avg_encode_time_ms); If you wanna, add two samples ...
5 years ago (2015-12-07 10:55:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278383002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278383002/120001
5 years ago (2015-12-07 11:09:41 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:120001)
5 years ago (2015-12-07 11:12:25 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-07 11:12:31 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1aa420b6aa70bd97cbe33e396e5dc0346aeb6415
Cr-Commit-Position: refs/heads/master@{#10911}

Powered by Google App Engine
This is Rietveld 408576698