Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1277263002: Add instrumentation to track the IceEndpointType. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index bdbc6a7e38c1e92b07a8e7ee778166bdd2f39abb..ac6280fc24b54045e5f9f8750b3fcddff952ffcb 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -126,7 +126,20 @@ class StatsObserver : public rtc::RefCountInterface {
class MetricsObserverInterface : public rtc::RefCountInterface {
public:
- virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0;
+ // TODO(guoweis): Remove this function once IncrementEnumCounter gets into
+ // chromium. IncrementCounter only deals with one type of enumeration counter,
+ // i.e. PeerConnectionAddressFamilyCounter. Instead of creating a function for
+ // each enum type, IncrementEnumCounter is generalized with the enum type
+ // parameter.
+ virtual void IncrementCounter(PeerConnectionAddressFamilyCounter type) {}
+
+ // |type| is the type of the enum counter to be incremented. |counter|
+ // is the particular counter in that type. |counter_max| is the next sequence
+ // number after the highest counter.
+ virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
+ int counter,
+ int counter_max) {}
+
virtual void AddHistogramSample(PeerConnectionMetricsName type,
int value) = 0;
// TODO(jbauch): Make method abstract when it is implemented by Chromium.
@@ -178,6 +191,7 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
kIceConnectionFailed,
kIceConnectionDisconnected,
kIceConnectionClosed,
+ kIceConnectionMax,
};
struct IceServer {

Powered by Google App Engine
This is Rietveld 408576698