Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: talk/app/webrtc/fakemetricsobserver.h

Issue 1277263002: Add instrumentation to track the IceEndpointType. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/fakemetricsobserver.cc » ('j') | talk/app/webrtc/fakemetricsobserver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/fakemetricsobserver.h
diff --git a/talk/app/webrtc/fakemetricsobserver.h b/talk/app/webrtc/fakemetricsobserver.h
index e9e49749bf104246b32dab0d3ebc124cc355cd2b..39454bf4db48862a32b0b7d7b64ed6a1bc184502 100644
--- a/talk/app/webrtc/fakemetricsobserver.h
+++ b/talk/app/webrtc/fakemetricsobserver.h
@@ -41,14 +41,16 @@ class FakeMetricsObserver : public MetricsObserverInterface {
FakeMetricsObserver();
void Reset();
- void IncrementCounter(PeerConnectionMetricsCounter type) override;
+ void IncrementEnumCounter(PeerConnectionEnumCounterType,
+ int counter,
+ int counter_max) override;
void AddHistogramSample(PeerConnectionMetricsName type,
int value) override;
void AddHistogramSample(PeerConnectionMetricsName type,
const std::string& value) override;
// Accessors to be used by the tests.
- int GetCounter(PeerConnectionMetricsCounter type) const;
+ int GetEnumCounter(PeerConnectionEnumCounterType type, int counter) const;
int GetIntHistogramSample(PeerConnectionMetricsName type) const;
const std::string& GetStringHistogramSample(
PeerConnectionMetricsName type) const;
@@ -58,8 +60,10 @@ class FakeMetricsObserver : public MetricsObserverInterface {
private:
rtc::ThreadChecker thread_checker_;
- int counters_[kPeerConnectionMetricsCounter_Max];
- int int_histogram_samples_[kPeerConnectionMetricsCounter_Max];
+ // This is a 2 dimension array. The first index is the enum counter type. The
+ // 2nd index is the counter of that particular enum counter type.
+ std::vector<std::vector<int>> counters_;
+ int int_histogram_samples_[kPeerConnectionMetricsName_Max];
std::string string_histogram_samples_[kPeerConnectionMetricsName_Max];
};
« no previous file with comments | « no previous file | talk/app/webrtc/fakemetricsobserver.cc » ('j') | talk/app/webrtc/fakemetricsobserver.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698