Chromium Code Reviews| Index: talk/app/webrtc/peerconnectioninterface.h |
| diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h |
| index ce32b50291a7a46c061bf36aabe9d7cf8d9096b2..a314a188daf24c871a5dfec9b2006dfec8c50572 100644 |
| --- a/talk/app/webrtc/peerconnectioninterface.h |
| +++ b/talk/app/webrtc/peerconnectioninterface.h |
| @@ -124,7 +124,20 @@ class StatsObserver : public rtc::RefCountInterface { |
| class MetricsObserverInterface : public rtc::RefCountInterface { |
| public: |
| - virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0; |
| + // TODO(guoweis): Remove this function once IncrementEnumCounter gets into |
| + // chromium. IncrementCounter only deals with one type of enumeration counter, |
| + // i.e. PeerConnectionAddressFamilyCounter. Instead of creating a function for |
| + // each enum type, IncrementEnumCounter is generalized with the enum type |
| + // parameter. |
| + virtual void IncrementCounter(PeerConnectionAddressFamilyCounter type) {} |
| + |
| + // |type| is the type of the enum counter to be incremented. |counter| |
| + // is the particular counter in that type. |counter_max| is the next sequence |
| + // number after the highest counter. |
| + virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type, |
| + int counter, |
| + int counter_max) {} |
| + |
| virtual void AddHistogramSample(PeerConnectionMetricsName type, |
| int value) = 0; |
| // TODO(jbauch): Make method abstract when it is implemented by Chromium. |
| @@ -176,6 +189,7 @@ class PeerConnectionInterface : public rtc::RefCountInterface { |
| kIceConnectionFailed, |
| kIceConnectionDisconnected, |
| kIceConnectionClosed, |
| + kIceConnectionStateMax, |
|
pthatcher1
2015/08/19 02:47:53
Can just be kIceConnectionMax (no "state")
guoweis_webrtc
2015/08/19 18:25:52
Done.
|
| }; |
| struct IceServer { |