Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1277263002: Add instrumentation to track the IceEndpointType. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/webrtcsession_unittest.cc
diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc
index de10bc40a8b432ba79a248d4a55b112f29f0d2e0..afb0e412a874414cf283c20b69ef45717d93280e 100644
--- a/talk/app/webrtc/webrtcsession_unittest.cc
+++ b/talk/app/webrtc/webrtcsession_unittest.cc
@@ -1005,12 +1005,20 @@ class WebRtcSessionTest : public testing::Test {
private:
void Verify(const rtc::scoped_refptr<FakeMetricsObserver> metrics_observer,
const ExpectedBestConnection& expected) const {
- EXPECT_EQ(
- metrics_observer->GetCounter(webrtc::kBestConnections_IPv4),
- expected.ipv4_count_);
- EXPECT_EQ(
- metrics_observer->GetCounter(webrtc::kBestConnections_IPv6),
- expected.ipv6_count_);
+ EXPECT_EQ(metrics_observer->GetCounter(
+ webrtc::kPeerConnectionEnumCounter_AddressFamily,
+ webrtc::kBestConnections_IPv4),
+ expected.ipv4_count_);
+ EXPECT_EQ(metrics_observer->GetCounter(
+ webrtc::kPeerConnectionEnumCounter_AddressFamily,
+ webrtc::kBestConnections_IPv6),
+ expected.ipv6_count_);
+ // This is used in the loopback call so there is only single host to host
+ // candidate pair.
+ EXPECT_EQ(metrics_observer->GetCounter(
+ webrtc::kPeerConnectionEnumCounter_IceCandidatePairTypeUdp,
+ webrtc::kIceCandidatePair_Host_Host),
+ 1);
}
};

Powered by Google App Engine
This is Rietveld 408576698