Add instrumentation to track the IceEndpointType.

talk/app/webrtc/peerconnectioninterface.h

Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index ce32b50291a7a46c061bf36aabe9d7cf8d9096b2..5e82ff7d093dc063808de7f2c1851db3ed992a4b 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -124,7 +124,20 @@ class StatsObserver : public rtc::RefCountInterface {
 
 class MetricsObserverInterface : public rtc::RefCountInterface {
  public:
-  virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0;
+  // TODO(guoweis): Remove this function once IncrementEnumCounter gets into
+  // chromium. IncrementCounter only deals with one type of enumeration counter,
+  // i.e. PeerConnectionAddressFamilyCounter. Instead of creating a function for
+  // each enum type, IncrementEnumCounter is generalized with the enum type
+  // parameter.
+  virtual void IncrementCounter(PeerConnectionAddressFamilyCounter type) {}
+
+  // |type| is the type of the enum counter to be incremented. |counter|
+  // is the particular counter in that type. |counter_max| is the next sequence
+  // number after the highest counter.
+  virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
+                                    int counter,
+                                    int counter_max) {}
+
   virtual void AddHistogramSample(PeerConnectionMetricsName type,
                                   int value) = 0;
   // TODO(jbauch): Make method abstract when it is implemented by Chromium.
@@ -178,6 +191,8 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
     kIceConnectionClosed,
   };
 
+  const int kIceConnectionState_Max = kIceConnectionClosed + 1;

[pthatcher1, 2015/08/18 18:06:22]

You could just put kIceConnectionStateMax at the end of the enum.

[guoweis_webrtc, 2015/08/18 22:33:57]

I was hesitant about this since all the states in enum is according to the spec.

+
   struct IceServer {
     // TODO(jbauch): Remove uri when all code using it has switched to urls.
     std::string uri;