Add instrumentation to track the IceEndpointType.

talk/app/webrtc/peerconnectioninterface.h

 /*
  * libjingle
  * Copyright 2012 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 106 matching lines @@
 class StatsObserver : public rtc::RefCountInterface {
  public:
   virtual void OnComplete(const StatsReports& reports) = 0;
 
  protected:
   virtual ~StatsObserver() {}
 };
 
 class MetricsObserverInterface : public rtc::RefCountInterface {
  public:
-  virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0;
+  // TODO(guoweis): Remove this function once IncrementEnumCounter gets into
+  // chromium. IncrementCounter only deals with one type of enumeration counter,
+  // i.e. PeerConnectionAddressFamilyCounter. Instead of creating a function for
+  // each enum type, IncrementEnumCounter is generalized with the enum type
+  // parameter.
+  virtual void IncrementCounter(PeerConnectionAddressFamilyCounter type) {}
+
+  // |type| is the type of the enum counter to be incremented. |counter|
+  // is the particular counter in that type. |counter_max| is the next sequence
+  // number after the highest counter.
+  virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
+                                    int counter,
+                                    int counter_max) {}
+
   virtual void AddHistogramSample(PeerConnectionMetricsName type,
                                   int value) = 0;
   // TODO(jbauch): Make method abstract when it is implemented by Chromium.
   virtual void AddHistogramSample(PeerConnectionMetricsName type,
                                   const std::string& value) {}
 
  protected:
   virtual ~MetricsObserverInterface() {}
 };
 
@@ skipping 33 matching lines @@
   enum IceConnectionState {
     kIceConnectionNew,
     kIceConnectionChecking,
     kIceConnectionConnected,
     kIceConnectionCompleted,
     kIceConnectionFailed,
     kIceConnectionDisconnected,
     kIceConnectionClosed,
   };
 
+  const int kIceConnectionState_Max = kIceConnectionClosed + 1;

[pthatcher1, 2015/08/18 18:06:22]

You could just put kIceConnectionStateMax at the end of the enum.

[guoweis_webrtc, 2015/08/18 22:33:57]

I was hesitant about this since all the states in enum is according to the spec.

+
   struct IceServer {
     // TODO(jbauch): Remove uri when all code using it has switched to urls.
     std::string uri;
     std::vector<std::string> urls;
     std::string username;
     std::string password;
   };
   typedef std::vector<IceServer> IceServers;
 
   enum IceTransportsType {
@@ skipping 436 matching lines @@
 CreatePeerConnectionFactory(
     rtc::Thread* worker_thread,
     rtc::Thread* signaling_thread,
     AudioDeviceModule* default_adm,
     cricket::WebRtcVideoEncoderFactory* encoder_factory,
     cricket::WebRtcVideoDecoderFactory* decoder_factory);
 
 }  // namespace webrtc
 
 #endif  // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_