Add instrumentation to track the IceEndpointType.

talk/app/webrtc/fakemetricsobserver.h

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 23 matching lines @@
 #include "talk/app/webrtc/peerconnectioninterface.h"
 #include "webrtc/base/thread_checker.h"
 
 namespace webrtc {
 
 class FakeMetricsObserver : public MetricsObserverInterface {
  public:
   FakeMetricsObserver();
   void Reset();
 
-  void IncrementCounter(PeerConnectionMetricsCounter type) override;
+  void IncrementEnumCounter(PeerConnectionEnumCounterType,
+                            int counter,
+                            int counter_max) override;
   void AddHistogramSample(PeerConnectionMetricsName type,
                           int value) override;
   void AddHistogramSample(PeerConnectionMetricsName type,
                           const std::string& value) override;
 
   // Accessors to be used by the tests.
-  int GetCounter(PeerConnectionMetricsCounter type) const;
+  int GetCounter(PeerConnectionEnumCounterType type, int counter) const;

[pthatcher1, 2015/08/18 18:06:22]

If you renamed one to IncrementEnumCounter, shouldn't you rename the other to
GetEnumCounter?

[guoweis_webrtc, 2015/08/18 22:33:57]

Done.

   int GetIntHistogramSample(PeerConnectionMetricsName type) const;
   const std::string& GetStringHistogramSample(
       PeerConnectionMetricsName type) const;
 
  protected:
   ~FakeMetricsObserver() {}
 
  private:
   rtc::ThreadChecker thread_checker_;
-  int counters_[kPeerConnectionMetricsCounter_Max];
-  int int_histogram_samples_[kPeerConnectionMetricsCounter_Max];
+  std::vector<std::vector<int>> counters_;

[pthatcher1, 2015/08/18 18:06:22]

Can you put a comment about what the indexes are (I'm assuming enum type, and
then counter, but a comment would help out).

[guoweis_webrtc, 2015/08/18 22:33:57]

Done.

+  int int_histogram_samples_[kPeerConnectionMetricsName_Max];

[pthatcher1, 2015/08/18 18:06:22]

It seems like you should have an array of vectors in counters_ or a a vector in
int_histogram_samples_ to make them consistent. 

[guoweis_webrtc, 2015/08/18 22:33:57]

histogram_samples use string to track each sample so they don't need this.

   std::string string_histogram_samples_[kPeerConnectionMetricsName_Max];
 };
 
 }  // namespace webrtc
 
 #endif  // TALK_APP_WEBRTC_FAKEMETRICSOBSERVER_H_