Issue 1276233006: Empty dtlsidentityservice.h/cc files added as to not break chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276233006: Empty dtlsidentityservice.h/cc files added as to not break chromium (Closed)

Created:
5 years, 4 months ago by hbos

Modified:
5 years, 4 months ago

Reviewers:
magjed_webrtc, tommi

CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Empty dtlsidentityservice.h/cc files added, to be removed once chromium gyp files don't reference it. This is CL is part of an effort to land https://codereview.webrtc.org/1176383004 without breaking Chromium. See bug for more information. BUG=webrtc:4899 TBR=tommi@webrtc.org,magjed@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/cc4ebadf0b5783fc46f1279534aa5e838945c5d7

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
	A +	talk/app/webrtc/dtlsidentityservice.h	View		2 chunks	+2 lines, -7 lines	0 comments	Download
	A +	talk/app/webrtc/dtlsidentityservice.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hbos

5 years, 4 months ago (2015-08-11 09:45:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc4ebadf0b5783fc46f1279534aa5e838945c5d7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages