Bug 4517: Enable connectivity for demo page when no STUN/TURN specifiefd.

Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied.

BUG=webrtc:4517
R=pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/0a2955f227666efd87b2a303a69c083ef801c528

[guoweis_webrtc, 2015-08-06 00:29:55]

Patchset #1 (id:1) has been deleted

[guoweis_webrtc, 2015-08-06 00:31:47]

Patchset #1 (id:20001) has been deleted

[guoweis_webrtc, 2015-08-06 00:35:17]

guoweis@webrtc.org changed reviewers:
+ jubert@webrtc.org, pthather@webrtc.org

[guoweis_webrtc, 2015-08-06 00:35:18]

PTAL.

[pthatcher1, 2015-08-07 21:59:49]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-08-07 21:59:49]

https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnectioninterface.h (right):

https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnectioninterface.h:225: // candidate in the case when
multiple_routes is disabled.
Would it be easier to reason about the rule "a localhost candidate is signaled
whenever a candidate with the any address is allocated"?

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
File webrtc/p2p/base/turnport_unittest.cc (right):

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
webrtc/p2p/base/turnport_unittest.cc:275: std::string(), false));
I'm still not a big fan of the parameter list growing so large.   Any idea of
how we can fix that?

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator.cc:832: config_->StunServers().empty() &&
config_->relays.empty();
Can we just check the flag here, and not check the servers?  Chrome shouldn't
set the flag unless it also doesn't set the servers, right?

[guoweis_webrtc, 2015-08-13 15:08:53]

PTAL.

https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnectioninterface.h (right):

https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnectioninterface.h:225: // candidate in the case when
multiple_routes is disabled.
On 2015/08/07 21:59:49, pthatcher1 wrote:
> Would it be easier to reason about the rule "a localhost candidate is signaled
> whenever a candidate with the any address is allocated"?

Done.

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
File webrtc/p2p/base/turnport_unittest.cc (right):

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
webrtc/p2p/base/turnport_unittest.cc:275: std::string(), false));
On 2015/08/07 21:59:49, pthatcher1 wrote:
> I'm still not a big fan of the parameter list growing so large.   Any idea of
> how we can fix that?

struct? 
min_port, max_port could be combined to port_range
username, password to credential?

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator.cc:832: config_->StunServers().empty() &&
config_->relays.empty();
On 2015/08/07 21:59:49, pthatcher1 wrote:
> Can we just check the flag here, and not check the servers?  Chrome shouldn't
> set the flag unless it also doesn't set the servers, right?

Done.

[guoweis_webrtc, 2015-08-14 20:12:10]

On 2015/08/13 15:08:53, guoweis wrote:
> PTAL.
> 
>
https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
> File talk/app/webrtc/peerconnectioninterface.h (right):
> 
>
https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
> talk/app/webrtc/peerconnectioninterface.h:225: // candidate in the case when
> multiple_routes is disabled.
> On 2015/08/07 21:59:49, pthatcher1 wrote:
> > Would it be easier to reason about the rule "a localhost candidate is
signaled
> > whenever a candidate with the any address is allocated"?
> 
> Done.
> 
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
> File webrtc/p2p/base/turnport_unittest.cc (right):
> 
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
> webrtc/p2p/base/turnport_unittest.cc:275: std::string(), false));
> On 2015/08/07 21:59:49, pthatcher1 wrote:
> > I'm still not a big fan of the parameter list growing so large.   Any idea
of
> > how we can fix that?
> 
> struct? 
> min_port, max_port could be combined to port_range
> username, password to credential?
> 
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
> File webrtc/p2p/client/basicportallocator.cc (right):
> 
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
> webrtc/p2p/client/basicportallocator.cc:832: config_->StunServers().empty() &&
> config_->relays.empty();
> On 2015/08/07 21:59:49, pthatcher1 wrote:
> > Can we just check the flag here, and not check the servers?  Chrome
shouldn't
> > set the flag unless it also doesn't set the servers, right?
> 
> Done.

Merge with the master branch. PTAL.

[guoweis_webrtc, 2015-08-18 17:13:49]

On 2015/08/14 20:12:10, guoweis wrote:
> On 2015/08/13 15:08:53, guoweis wrote:
> > PTAL.
> > 
> >
>
https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
> > File talk/app/webrtc/peerconnectioninterface.h (right):
> > 
> >
>
https://codereview.webrtc.org/1275703006/diff/40001/talk/app/webrtc/peerconne...
> > talk/app/webrtc/peerconnectioninterface.h:225: // candidate in the case when
> > multiple_routes is disabled.
> > On 2015/08/07 21:59:49, pthatcher1 wrote:
> > > Would it be easier to reason about the rule "a localhost candidate is
> signaled
> > > whenever a candidate with the any address is allocated"?
> > 
> > Done.
> > 
> >
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
> > File webrtc/p2p/base/turnport_unittest.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/base/turnport_...
> > webrtc/p2p/base/turnport_unittest.cc:275: std::string(), false));
> > On 2015/08/07 21:59:49, pthatcher1 wrote:
> > > I'm still not a big fan of the parameter list growing so large.   Any idea
> of
> > > how we can fix that?
> > 
> > struct? 
> > min_port, max_port could be combined to port_range
> > username, password to credential?
> > 
> >
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
> > File webrtc/p2p/client/basicportallocator.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1275703006/diff/40001/webrtc/p2p/client/basicpo...
> > webrtc/p2p/client/basicportallocator.cc:832: config_->StunServers().empty()
&&
> > config_->relays.empty();
> > On 2015/08/07 21:59:49, pthatcher1 wrote:
> > > Can we just check the flag here, and not check the servers?  Chrome
> shouldn't
> > > set the flag unless it also doesn't set the servers, right?
> > 
> > Done.
> 
> Merge with the master branch. PTAL.

Ping.

[pthatcher1, 2015-08-18 18:52:50]

lgtm, with nits

https://codereview.webrtc.org/1275703006/diff/80001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnectioninterface.h (right):

https://codereview.webrtc.org/1275703006/diff/80001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnectioninterface.h:226: // a localhost candidate is
signaled whenever a candidate with the any
a => A

https://codereview.webrtc.org/1275703006/diff/80001/webrtc/p2p/base/portalloc...
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/1275703006/diff/80001/webrtc/p2p/base/portalloc...
webrtc/p2p/base/portallocator.h:186: bool emit_localhost_for_anyaddress_;
Please remove

[guoweis_webrtc, 2015-08-18 20:05:35]

Committed patchset #4 (id:100001) manually as
0a2955f227666efd87b2a303a69c083ef801c528 (presubmit successful).

[guoweis_webrtc, 2015-08-19 18:30:08]

The CQ bit was checked by guoweis@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 18:30:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275703006/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275703006/140001

[commit-bot: I haz the power, 2015-08-19 20:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 20:30:29]

Dry run: Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[guoweis_webrtc, 2015-08-19 20:49:34]

The CQ bit was checked by guoweis@webrtc.org

[guoweis_webrtc, 2015-08-19 20:49:35]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1275703006/#ps140001 (title:
" ")

[commit-bot: I haz the power, 2015-08-19 20:49:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275703006/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275703006/140001

[guoweis_webrtc, 2015-08-19 20:56:06]

The CQ bit was unchecked by guoweis@webrtc.org

[guoweis_webrtc, 2015-08-19 21:10:38]

Patchset #7 (id:160001) has been deleted

[guoweis_webrtc, 2015-10-20 17:17:58]

A revert of this CL (patchset #6 id:140001) has been created in
https://codereview.webrtc.org/1413423002/ by guoweis@webrtc.org.

The reason for reverting is: Generate a revert CL since we don't need this
loopback address anymore. This is not sent to CQ..