Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1274273005: Revert "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becau… (Closed)

Created:
5 years, 4 months ago by pthatcher1
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots. This reverts commit 3449faa553ec94c52ef2d0949867befb60992c88. TBR=deadbeef@webrtc.org, juberti@webrtc.org NOPRESUBMIT=true Committed: https://crrev.com/fa301809b698017455847f45cc7e0dfa1bdfed35 Cr-Commit-Position: refs/heads/master@{#9698}

Patch Set 1 #

Patch Set 2 : Increase STUN RTOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M webrtc/p2p/base/stunrequest.cc View 1 3 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pthatcher1
5 years, 4 months ago (2015-08-10 20:04:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274273005/1
5 years, 4 months ago (2015-08-11 09:31:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/336)
5 years, 4 months ago (2015-08-11 09:34:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274273005/1
5 years, 4 months ago (2015-08-11 11:12:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 11:13:01 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 11:13:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa301809b698017455847f45cc7e0dfa1bdfed35
Cr-Commit-Position: refs/heads/master@{#9698}

Powered by Google App Engine
This is Rietveld 408576698