Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java

Issue 1273803002: Android VideoRendererGui: Add dispose function (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java
diff --git a/talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java b/talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java
index 401640b463bfdfff7f832ebf75ce73100a0b40fb..9a7e292e62e4dd189d71d1b1e2c7e53c83ef663f 100644
--- a/talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java
+++ b/talk/app/webrtc/java/src/org/webrtc/VideoRenderer.java
@@ -179,7 +179,7 @@ public class VideoRenderer {
// |this| either wraps a native (GUI) renderer or a client-supplied Callbacks
// (Java) implementation; so exactly one of these will be non-0/null.
final long nativeVideoRenderer;
- private final Callbacks callbacks;
+ private Callbacks callbacks;
public static VideoRenderer createGui(int x, int y) {
long nativeVideoRenderer = nativeCreateGuiVideoRenderer(x, y);
@@ -203,6 +203,7 @@ public class VideoRenderer {
if (callbacks == null) {
freeGuiVideoRenderer(nativeVideoRenderer);
} else {
+ callbacks = null;
freeWrappedVideoRenderer(nativeVideoRenderer);
}
AlexG 2015/08/05 18:19:23 set nativeVideoRenderer to 0 and add a check at th
magjed_webrtc 2015/08/11 10:38:16 Done. I also changed |callbacks| to a boolean inst
}

Powered by Google App Engine
This is Rietveld 408576698