Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. | 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
| 5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
| 6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
| 7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
| 8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
| 9 */ | 9 */ |
| 10 | 10 |
| 11 #include "webrtc/video/transport_adapter.h" | 11 #include "webrtc/video/transport_adapter.h" |
| 12 #include "webrtc/base/checks.h" | |
| 12 | 13 |
| 13 namespace webrtc { | 14 namespace webrtc { |
| 14 namespace internal { | 15 namespace internal { |
| 15 | 16 |
| 16 TransportAdapter::TransportAdapter(newapi::Transport* transport) | 17 TransportAdapter::TransportAdapter(newapi::Transport* transport) |
| 17 : transport_(transport), enabled_(0) {} | 18 : transport_(transport), enabled_(0) { |
| 19 DCHECK(nullptr != transport); | |
|
pbos-webrtc
2015/08/26 12:21:22
pref transport != nullptr
the sun
2015/08/27 08:42:21
Why? I usually write conditionals with a non-assig
pbos-webrtc
2015/08/27 09:02:01
Reads more like english "check that transport isn'
| |
| 20 } | |
| 18 | 21 |
| 19 int TransportAdapter::SendPacket(int /*channel*/, | 22 int TransportAdapter::SendPacket(int /*channel*/, |
| 20 const void* packet, | 23 const void* packet, |
| 21 size_t length) { | 24 size_t length) { |
| 22 if (enabled_.Value() == 0) | 25 if (enabled_.Value() == 0) |
| 23 return false; | 26 return false; |
| 24 | 27 |
| 25 bool success = transport_->SendRtp(static_cast<const uint8_t*>(packet), | 28 bool success = transport_->SendRtp(static_cast<const uint8_t*>(packet), |
| 26 length); | 29 length); |
| 27 return success ? static_cast<int>(length) : -1; | 30 return success ? static_cast<int>(length) : -1; |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 41 void TransportAdapter::Enable() { | 44 void TransportAdapter::Enable() { |
| 42 // If this exchange fails it means enabled_ was already true, no need to | 45 // If this exchange fails it means enabled_ was already true, no need to |
| 43 // check result and iterate. | 46 // check result and iterate. |
| 44 enabled_.CompareExchange(1, 0); | 47 enabled_.CompareExchange(1, 0); |
| 45 } | 48 } |
| 46 | 49 |
| 47 void TransportAdapter::Disable() { enabled_.CompareExchange(0, 1); } | 50 void TransportAdapter::Disable() { enabled_.CompareExchange(0, 1); } |
| 48 | 51 |
| 49 } // namespace internal | 52 } // namespace internal |
| 50 } // namespace webrtc | 53 } // namespace webrtc |
| OLD | NEW |