Replaced the wav file dumping functionality in aec_core.c with the newly added corresponding macros

webrtc/modules/audio_processing/logging/aec_logging_file_handling.h

+/*
+ *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_AEC_AEC_LOGGING_FILE_HANDLING_
+#define WEBRTC_MODULES_AUDIO_PROCESSING_AEC_AEC_LOGGING_FILE_HANDLING_
+
+// To enable AEC logging, run this command from trunk/ :
+// python webrtc/build/gyp_webrtc -Daec_debug_dump=1

[Andrew MacDonald, 2015/08/10 15:25:55]

I would instead just say:
"To enable AEC logging, enable the gyp variable aec_debug_dump=1."

There are multiple ways to enable gyp variables.

[peah-webrtc, 2015/08/12 20:25:53]

Done.

+#ifdef WEBRTC_AEC_DEBUG_DUMP
+#include <stdio.h>

[Andrew MacDonald, 2015/08/10 15:25:55]

nit: blank line after this.

[peah-webrtc, 2015/08/12 20:25:53]

Done.

+#include "webrtc/common_audio/wav_file.h"
+#include "webrtc/typedefs.h"
+#endif
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#ifdef WEBRTC_AEC_DEBUG_DUMP
+// (Re)open wav file using the specified sample rate
+void WebRtcAec_ReopenWav(rtc_WavWriter** wav_file,
+                         const char* const name,
+                         const int seq1,
+                         const int seq2,
+                         const int sample_rate);

[kwiberg-webrtc, 2015/08/10 20:19:57]

Marking parameters const in function declarations is just noise to callers, so
there's little point in doing it. (But not entirely pointless. IIRC, gcc and
clang will let you have the consts in the definition but not in the declaration,
which is what you'd want, but Visual C++ complains about that. Still, they're
not generally worth it.)

[peah-webrtc, 2015/08/12 20:25:53]

Done.

+
+// Open dumpfile with instance-specific filename
+void WebRtcAec_RawFileOpen(FILE** file,
+                           const char * const name,

[kwiberg-webrtc, 2015/08/10 20:19:57]

In the night sky, stars appear surrounded by empty space on all sides, but
that's just because they're far enough away that the light that you see was
emitted before our style guide went into effect.

[peah-webrtc, 2015/08/12 20:25:53]

Done.

[peah-webrtc, 2015/08/12 20:25:53]

Wonderful comment! :-) (and of course you are right, will do the change :-) )

Done!

+                           const int16_t instanceCtr);

[kwiberg-webrtc, 2015/08/10 20:19:57]

Why not int? (That's what you always should pick unless you have a good reason.)

[hlundin-webrtc, 2015/08/12 11:48:18]

Acknowledged.

[peah-webrtc, 2015/08/12 20:25:53]

Done.

+
+#endif  // WEBRTC_AEC_DEBUG_DUMP
+
+

[Andrew MacDonald, 2015/08/10 15:25:55]

Remove blank line.

[peah-webrtc, 2015/08/12 20:25:53]

Done.

+#ifdef __cplusplus
+}
+#endif
+
+#endif  // WEBRTC_MODULES_AUDIO_PROCESSING_AEC_AEC_LOGGING_FILE_HANDLING_