Separating voice activity flag from audio level in RtpHeaderExtension.

Separating voice activity flag from audio level in RtpHeaderExtension.

VAD flag was embedded in RtpHeaderExtension.audioLevel, which is not easy to interpret. This CL tries to separate the flag with the actual audio level.

BUG=
R=andrew@webrtc.org, henrik.lundin@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/4cee419e0777dcbfbd0837e26bed202e35e696a9

[minyue-webrtc, 2015-08-05 21:50:48]

Patchset #1 (id:1) has been deleted

[minyue-webrtc, 2015-08-05 21:52:43]

minyue@webrtc.org changed reviewers:
+ andrew@webrtc.org, henrik.lundin@webrtc.org

[minyue-webrtc, 2015-08-05 21:55:03]

Patchset #1 (id:20001) has been deleted

[minyue-webrtc, 2015-08-05 22:07:34]

Hi Andrew and Henrik,

Would you take a look at this CL?

[hlundin-webrtc, 2015-08-06 07:41:21]

Nice! LGTM.

I trust you have searched for all uses of RTPHeaderExtension.audioLevel in the
code base and updated it accordingly.

Thanks!
/HL

[minyue-webrtc, 2015-08-10 09:38:40]

On 2015/08/06 07:41:21, hlundin-webrtc wrote:
> Nice! LGTM.
> 
> I trust you have searched for all uses of RTPHeaderExtension.audioLevel in the
> code base and updated it accordingly.
> 
> Thanks!
> /HL

Hi Andrew,

Could you take a look at this? I also need your owner's approval.

[Andrew MacDonald, 2015-08-10 13:00:46]

lgtm, nice cleanup. One change to make.

https://codereview.webrtc.org/1272343003/diff/40001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_utility.cc (right):

https://codereview.webrtc.org/1272343003/diff/40001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_utility.cc:428: // Parse out the fields but
only use it for debugging for now.
Remove this commented block please. It's redundant.

[minyue-webrtc, 2015-08-10 13:08:53]

Committed patchset #2 (id:60001) manually as
4cee419e0777dcbfbd0837e26bed202e35e696a9 (presubmit successful).