First step of passive aggressive nomination.

webrtc/p2p/base/port.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 869 matching lines @@
                        size_t index,
                        const Candidate& remote_candidate)
     : port_(port),
       local_candidate_index_(index),
       remote_candidate_(remote_candidate),
       read_state_(STATE_READ_INIT),
       write_state_(STATE_WRITE_INIT),
       connected_(true),
       pruned_(false),
       use_candidate_attr_(false),
+      nominated_(false),
       remote_ice_mode_(ICEMODE_FULL),
       requests_(port->thread()),
       rtt_(DEFAULT_RTT),
       last_ping_sent_(0),
       last_ping_received_(0),
       last_data_received_(0),
       last_ping_response_received_(0),
       sent_packets_discarded_(0),
       sent_packets_total_(0),
       reported_(false),
@@ skipping 150 matching lines @@
 
           // If timed out sending writability checks, start up again
           if (!pruned_ && (write_state_ == STATE_WRITE_TIMEOUT))
             set_write_state(STATE_WRITE_INIT);
 
           if ((port_->IsStandardIce()) &&
               (port_->GetIceRole() == ICEROLE_CONTROLLED)) {
             const StunByteStringAttribute* use_candidate_attr =
                 msg->GetByteString(STUN_ATTR_USE_CANDIDATE);
             if (use_candidate_attr)
-              SignalUseCandidate(this);
+              set_nominated(true);
           }
         } else {
           // The packet had the right local username, but the remote username
           // was not the right one for the remote address.
           LOG_J(LS_ERROR, this)
             << "Received STUN request with bad remote username "
             << remote_ufrag;
           port_->SendBindingErrorResponse(msg.get(), addr,
                                           STUN_ERROR_UNAUTHORIZED,
                                           STUN_ERROR_REASON_UNAUTHORIZED);
@@ skipping 395 matching lines @@
 }
 
 size_t Connection::sent_discarded_packets() {
   return sent_packets_discarded_;
 }
 
 size_t Connection::sent_total_packets() {
   return sent_packets_total_;
 }
 
+void Connection::set_nominated(bool nominated) {
+  nominated_ = nominated;
+  if (nominated_) {
+    SignalUseCandidate(this);

[juberti1, 2015/08/07 01:31:19]

This seems like an unexpected side effect. I would suggest that the code that
calls set_nominated just invoke the relevant OnUseCandidate logic directly.

[honghaiz3, 2015/08/07 20:42:04]

Done.

+  }
+}
+
 void Connection::MaybeAddPrflxCandidate(ConnectionRequest* request,
                                         StunMessage* response) {
   // RFC 5245
   // The agent checks the mapped address from the STUN response.  If the
   // transport address does not match any of the local candidates that the
   // agent knows about, the mapped address represents a new candidate -- a
   // peer reflexive candidate.
   const StunAddressAttribute* addr =
       response->GetAddress(STUN_ATTR_XOR_MAPPED_ADDRESS);
   if (!addr) {
@@ skipping 70 matching lines @@
     ASSERT(sent < 0);
     error_ = port_->GetError();
     sent_packets_discarded_++;
   } else {
     send_rate_tracker_.Update(sent);
   }
   return sent;
 }
 
 }  // namespace cricket