Add list of devices with HW H.264 encoder non suitable for WebRTC.

Add list of devices with HW H.264 encoder non suitable for WebRTC.

For now add only Galaxy S4 to the list, since its H.264 HW encoder
generates two times lower bitrate comparing to target.
Also use VBR mode for H.264 encoder configuration.

R=wzh@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/0c850202fe76ae55401028217302a11a7c0d0a19

[AlexG, 2015-08-03 22:02:32]

glaznev@webrtc.org changed reviewers:
+ wzh@webrtc.org

[AlexG, 2015-08-03 22:02:33]

PTAL

[wzh, 2015-08-04 16:46:25]

lgtm

https://codereview.webrtc.org/1270603007/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1270603007/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:77: // HW H.264
encoder on Galaxy S4 generates 2 times lower bitrate comparing to target.
nit: breaks into two lines.

https://codereview.webrtc.org/1270603007/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:126: Log.w(TAG,
"Model: " + Build.MODEL + " has black listed H.264 encoder.");
nit: assume 80 chars limit. break it into two lines.

[AlexG, 2015-08-04 17:25:35]

https://codereview.webrtc.org/1270603007/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1270603007/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:77: // HW H.264
encoder on Galaxy S4 generates 2 times lower bitrate comparing to target.
On 2015/08/04 16:46:25, wzh wrote:
> nit: breaks into two lines.

Done.

https://codereview.webrtc.org/1270603007/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java:126: Log.w(TAG,
"Model: " + Build.MODEL + " has black listed H.264 encoder.");
On 2015/08/04 16:46:25, wzh wrote:
> nit: assume 80 chars limit. break it into two lines.

Done.

[AlexG, 2015-08-04 17:25:58]

The CQ bit was checked by glaznev@webrtc.org

[AlexG, 2015-08-04 17:25:58]

The patchset sent to the CQ was uploaded after l-g-t-m from wzh@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1270603007/#ps20001 (title:
"Addressing comments.")

[commit-bot: I haz the power, 2015-08-04 17:26:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1270603007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1270603007/20001

[commit-bot: I haz the power, 2015-08-04 17:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-04 17:26:10]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[AlexG, 2015-08-04 17:27:11]

Committed patchset #2 (id:20001) manually as
0c850202fe76ae55401028217302a11a7c0d0a19 (presubmit successful).