Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc

Issue 1270543002: Supporting Pause/Resume, Sending Estimate logging. Corrected plot colors (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed PacketSender member from MetricRecorder Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc b/webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc
index 7032b08456b2e3aa53a7c57d875a738a03d26afa..0edfeca4a6fc5abe88ca81df8fe97bff3fbd30a4 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc
@@ -44,10 +44,11 @@ PacketReceiver::PacketReceiver(PacketProcessorListener* listener,
// Metric recorder plots them in separated figures,
// alignment will take place with the #1 left axis.
- prefixes.push_back("Throughput_kbps#1"); // Throughput.
- prefixes.push_back("Delay_ms_#1"); // Delay.
- prefixes.push_back("Packet_Loss_#1"); // Loss.
- prefixes.push_back("Objective_function_#1"); // Objective.
+ prefixes.push_back("Throughput_kbps#1");
+ prefixes.push_back("Sending_Estimate_kbps#1");
+ prefixes.push_back("Delay_ms_#1");
+ prefixes.push_back("Packet_Loss_#1");
+ prefixes.push_back("Objective_function_#1");
// Plot Total/PerFlow Available capacity together with throughputs.
prefixes.push_back("Throughput_kbps#1"); // Total Available.
@@ -93,7 +94,7 @@ void PacketReceiver::RunFor(int64_t time_ms, Packets* in_out) {
delay_stats_.Push(arrival_time_ms - send_time_ms);
if (metric_recorder_ != nullptr) {
- metric_recorder_->UpdateTime(arrival_time_ms);
+ metric_recorder_->UpdateTimeMs(arrival_time_ms);
UpdateMetrics(arrival_time_ms, send_time_ms,
media_packet->payload_size());
metric_recorder_->PlotAllDynamics();
@@ -119,7 +120,7 @@ void PacketReceiver::UpdateMetrics(int64_t arrival_time_ms,
int64_t send_time_ms,
size_t payload_size) {
metric_recorder_->UpdateThroughput(bwe_receiver_->RecentKbps(), payload_size);
- metric_recorder_->UpdateDelay(arrival_time_ms - send_time_ms);
+ metric_recorder_->UpdateDelayMs(arrival_time_ms - send_time_ms);
metric_recorder_->UpdateLoss(bwe_receiver_->RecentPacketLossRatio());
metric_recorder_->UpdateObjective();
}

Powered by Google App Engine
This is Rietveld 408576698