Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270543002: Supporting Pause/Resume, Sending Estimate logging. Corrected plot colors (Closed)

Created:
5 years, 4 months ago by magalhaesc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Supporting Pause/Resume, Sending Estimate logging. Corrected plot colors PacketSender can now log Pause/Resume events into a MetricRecorder. Solved estimate error and optimal bitrate issue for test 5.7 (multiple short TCP flows). Added Sending Estimate logging and plotting. Fixed plotting issue on plot_dynamics.py Now RMCAT lines with the same color (in different boxes) correspond to the same flow. Adjusting plot_dynamics.py font size according to number of variables. R=asapersson@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2386a45dc710f74174ae8b3ba18b744839b969d9

Patch Set 1 : Supporting Pause/Resume, Sending Estimate logging. Corrected plot colors #

Patch Set 2 : Added math.h. Sending estimate isn't plotted by default #

Patch Set 3 : Addressing nullptr PacketSender in MetricRecorder constructor #

Patch Set 4 : Recording bitrate only if MetricRecorder is set #

Total comments: 2

Patch Set 5 : Removed PacketSender member from MetricRecorder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -66 lines) Patch
M webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h View 1 2 3 4 4 chunks +8 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/metric_recorder.cc View 1 2 3 4 9 chunks +15 lines, -8 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/metric_recorder_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_receiver.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 4 chunks +17 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 2 3 8 chunks +45 lines, -18 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.py View 1 4 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
magalhaesc
Added math.h. Sending estimate isn't plotted by default
5 years, 4 months ago (2015-07-30 14:15:39 UTC) #1
magalhaesc
5 years, 4 months ago (2015-07-30 14:22:31 UTC) #3
magalhaesc
Addressing nullptr PacketSender in MetricRecorder constructor
5 years, 4 months ago (2015-07-30 14:33:20 UTC) #4
magalhaesc
Recording bitrate only if MetricRecorder is set
5 years, 4 months ago (2015-07-30 14:52:58 UTC) #5
åsapersson
lgtm https://codereview.webrtc.org/1270543002/diff/60001/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h File webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h (right): https://codereview.webrtc.org/1270543002/diff/60001/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h#newcode27 webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h:27: class ChokeFilter; nit: alphabetic order
5 years, 4 months ago (2015-07-30 15:39:53 UTC) #6
magalhaesc
Comment addressed https://codereview.webrtc.org/1270543002/diff/60001/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h File webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h (right): https://codereview.webrtc.org/1270543002/diff/60001/webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h#newcode27 webrtc/modules/remote_bitrate_estimator/test/metric_recorder.h:27: class ChokeFilter; On 2015/07/30 15:39:53, asapersson wrote: ...
5 years, 4 months ago (2015-07-30 15:53:18 UTC) #7
magalhaesc
Removed PacketSender member from MetricRecorder
5 years, 4 months ago (2015-07-30 16:31:08 UTC) #8
magalhaesc
5 years, 4 months ago (2015-07-31 08:31:51 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
2386a45dc710f74174ae8b3ba18b744839b969d9.

Powered by Google App Engine
This is Rietveld 408576698