Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1270403007: Revert H.264 HW encoder setting to CBR mode. (Closed)

Created:
5 years, 4 months ago by AlexG
Modified:
5 years, 4 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert H.264 HW encoder setting to CBR mode. VBR mode does not work well on KK devices - bitrate deviations from target are too large, R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8a2cd3d57da1eb0494aff3b14a7ff34fe97fd5ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
AlexG
PTAL
5 years, 4 months ago (2015-08-11 18:30:00 UTC) #2
wzh
lgtm
5 years, 4 months ago (2015-08-11 18:30:48 UTC) #3
AlexG
5 years, 4 months ago (2015-08-11 18:33:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a2cd3d57da1eb0494aff3b14a7ff34fe97fd5ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698