Issue 1270403007: Revert H.264 HW encoder setting to CBR mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1270403007: Revert H.264 HW encoder setting to CBR mode. (Closed)

Created:
5 years, 4 months ago by AlexG

Modified:
5 years, 4 months ago

Reviewers:
wzh

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Revert H.264 HW encoder setting to CBR mode. VBR mode does not work well on KK devices - bitrate deviations from target are too large, R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8a2cd3d57da1eb0494aff3b14a7ff34fe97fd5ef

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoEncoder.java	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

AlexG

5 years, 4 months ago (2015-08-11 18:33:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a2cd3d57da1eb0494aff3b14a7ff34fe97fd5ef (presubmit successful).