Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: talk/session/media/channelmanager.h

Issue 1269863005: MediaController/Call instantiation. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove redundant reset(nullptr) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine_unittest.cc ('k') | talk/session/media/channelmanager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/session/media/channelmanager.h
diff --git a/talk/session/media/channelmanager.h b/talk/session/media/channelmanager.h
index 81cb3eed61e591e3d8c0b3bc9ac457d8125f496d..3bfef84de2915328c514e3e7d149753557fcbf90 100644
--- a/talk/session/media/channelmanager.h
+++ b/talk/session/media/channelmanager.h
@@ -40,6 +40,9 @@
#include "webrtc/base/sigslotrepeater.h"
#include "webrtc/base/thread.h"
+namespace webrtc {
+class MediaControllerInterface;
+}
namespace cricket {
const int kDefaultAudioDelayOffset = 0;
@@ -81,6 +84,8 @@ class ChannelManager : public rtc::MessageHandler,
return true;
}
+ MediaEngineInterface* media_engine() { return media_engine_.get(); }
+
// Gets capabilities. Can be called prior to starting the media engine.
int GetCapabilities();
@@ -102,25 +107,22 @@ class ChannelManager : public rtc::MessageHandler,
// The operations below all occur on the worker thread.
// Creates a voice channel, to be associated with the specified session.
- VoiceChannel* CreateVoiceChannel(BaseSession* session,
- const std::string& content_name,
- bool rtcp,
- const AudioOptions& options);
+ VoiceChannel* CreateVoiceChannel(
+ webrtc::MediaControllerInterface* media_controller,
+ BaseSession* session,
+ const std::string& content_name,
+ bool rtcp,
+ const AudioOptions& options);
// Destroys a voice channel created with the Create API.
- void DestroyVoiceChannel(VoiceChannel* voice_channel,
- VideoChannel* video_channel);
- // TODO(pbos): Remove as soon as all call sites specify VideoOptions.
- VideoChannel* CreateVideoChannel(BaseSession* session,
- const std::string& content_name,
- bool rtcp,
- VoiceChannel* voice_channel);
+ void DestroyVoiceChannel(VoiceChannel* voice_channel);
// Creates a video channel, synced with the specified voice channel, and
// associated with the specified session.
- VideoChannel* CreateVideoChannel(BaseSession* session,
- const std::string& content_name,
- bool rtcp,
- const VideoOptions& options,
- VoiceChannel* voice_channel);
+ VideoChannel* CreateVideoChannel(
+ webrtc::MediaControllerInterface* media_controller,
+ BaseSession* session,
+ const std::string& content_name,
+ bool rtcp,
+ const VideoOptions& options);
// Destroys a video channel created with the Create API.
void DestroyVideoChannel(VideoChannel* video_channel);
DataChannel* CreateDataChannel(
@@ -247,17 +249,19 @@ class ChannelManager : public rtc::MessageHandler,
bool InitMediaEngine_w();
void DestructorDeletes_w();
void Terminate_w();
- VoiceChannel* CreateVoiceChannel_w(BaseSession* session,
- const std::string& content_name,
- bool rtcp,
- const AudioOptions& options);
- void DestroyVoiceChannel_w(VoiceChannel* voice_channel,
- VideoChannel* video_channel);
- VideoChannel* CreateVideoChannel_w(BaseSession* session,
- const std::string& content_name,
- bool rtcp,
- const VideoOptions& options,
- VoiceChannel* voice_channel);
+ VoiceChannel* CreateVoiceChannel_w(
+ webrtc::MediaControllerInterface* media_controller,
+ BaseSession* session,
+ const std::string& content_name,
+ bool rtcp,
+ const AudioOptions& options);
+ void DestroyVoiceChannel_w(VoiceChannel* voice_channel);
+ VideoChannel* CreateVideoChannel_w(
+ webrtc::MediaControllerInterface* media_controller,
+ BaseSession* session,
+ const std::string& content_name,
+ bool rtcp,
+ const VideoOptions& options);
void DestroyVideoChannel_w(VideoChannel* video_channel);
DataChannel* CreateDataChannel_w(
BaseSession* session, const std::string& content_name,
« no previous file with comments | « talk/media/webrtc/webrtcvoiceengine_unittest.cc ('k') | talk/session/media/channelmanager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698