Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/libjingle.gyp

Index: talk/libjingle.gyp
diff --git a/talk/libjingle.gyp b/talk/libjingle.gyp
index 15272519a2835b73404d76a3e99ae1b3a0633951..6f3fc5a96d18b493a569be941b0704fc2180be17 100755
--- a/talk/libjingle.gyp
+++ b/talk/libjingle.gyp
@@ -697,6 +697,7 @@
       'type': 'static_library',
       'dependencies': [
         'libjingle',
+        'libjingle_dtls',
         'libjingle_media',
         'libjingle_p2p',
       ],
@@ -708,8 +709,6 @@
         'app/webrtc/datachannel.cc',
         'app/webrtc/datachannel.h',
         'app/webrtc/datachannelinterface.h',
-        'app/webrtc/dtlsidentitystore.cc',
-        'app/webrtc/dtlsidentitystore.h',
         'app/webrtc/dtmfsender.cc',
         'app/webrtc/dtmfsender.h',
         'app/webrtc/dtmfsenderinterface.h',
@@ -780,5 +779,15 @@
         }],
       ],
     },  # target libjingle_peerconnection
+    {
+      'target_name': 'libjingle_dtls',

[Henrik Grunell WebRTC, 2015/08/12 14:46:30]

Any reason for putting this in its own target?

[hbos, 2015/08/14 14:09:39]

Yes, I wrote a comment about this that was hidden by other patch sets:
"dtlscertificate is used by both libjingle_peerconnection and
webrtc/base/base.gyp:rtc_base. I created a new build target to avoid .gyp
issues.

Details as remembered:

Having dtlscertificate in libjingle_peerconnection's sources works for making
libjingle_peerconnection and related stuff compile, but compiling rtc_base would
not work with just that.
Making rtc_base depend on libjingle_peerconnection causes a circular dependency
and does not compile (I drew a graph :) ).
I tried to also add it to rtc_base's sources but then dtlscertificate would be
compiled multiple times causing "defined multiple times" errors. Having
dtlscertificate be in rtc_base's sources alone, and not in
libjingle_peerconnection's sources, compiled locally but that caused a presubmit
error saying something like you're not allowed to have source files that are not
in the .gyp file's folder or subfolders.

This stand-alone build target can be referenced by both libjingle_peerconnection
and rtc_base without the above mentioned issues. Hope that's OK with the gyp
gurus."

[Henrik Grunell WebRTC, 2015/08/18 14:25:11]

Acknowledged.

+      'type': 'static_library',
+      'sources': [
+        'app/webrtc/dtlscertificate.cc',
+        'app/webrtc/dtlscertificate.h',
+        'app/webrtc/dtlsidentitystore.cc',
+        'app/webrtc/dtlsidentitystore.h',
+      ],
+    },  # target libjingle_dtls
   ],
 }