Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/dtlscertificate.h

Index: talk/app/webrtc/dtlscertificate.h
diff --git a/talk/app/webrtc/dtlsidentityservice.cc b/talk/app/webrtc/dtlscertificate.h
similarity index 67%
copy from talk/app/webrtc/dtlsidentityservice.cc
copy to talk/app/webrtc/dtlscertificate.h
index b4b7279c8288395a8e23a507f7c78dc199572cab..3cc05f1eee5c9075b903fb67ec30810e74cc9e1b 100644
--- a/talk/app/webrtc/dtlsidentityservice.cc
+++ b/talk/app/webrtc/dtlscertificate.h
@@ -25,26 +25,35 @@
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "talk/app/webrtc/dtlsidentityservice.h"
+#ifndef TALK_APP_WEBRTC_DTLSCERTIFICATE_H_
+#define TALK_APP_WEBRTC_DTLSCERTIFICATE_H_
 
-#include "talk/app/webrtc/dtlsidentitystore.h"
-#include "webrtc/base/logging.h"
+#include <string>
+
+#include "webrtc/base/refcount.h"
+#include "webrtc/base/scoped_ptr.h"
+#include "webrtc/base/scoped_ref_ptr.h"
+#include "webrtc/base/sslidentity.h"
 
 namespace webrtc {

[hbos, 2015/08/10 15:10:18]

Hmh... should I use the webrtc or rtc namespace for this? SSLIdentity is in rtc.
Not sure what the namespaces imply.

A question along the same lines is whether this belongs here, in
talk/app/webrtc/, or in webrtc/base/ where SSLIdentity is located. I placed it
in talk/app/webrtc and used the webrtc namespace simply because that's where the
dtlsidentitystore & -service was located.

 
-bool DtlsIdentityService::RequestIdentity(
-    const std::string& identity_name,
-    const std::string& common_name,
-    webrtc::DTLSIdentityRequestObserver* observer) {
-  if (identity_name != DtlsIdentityStore::kIdentityName ||
-      common_name != DtlsIdentityStore::kIdentityName) {
-    LOG(LS_WARNING) << "DtlsIdentityService::RequestIdentity called with "
-                    << "unsupported params, identity_name=" << identity_name
-                    << ", common_name=" << common_name;
-    return false;
-  }
-  store_->RequestIdentity(observer);
-  return true;
-}
+class DtlsCertificate : public rtc::RefCountInterface {
+ public:
+  static rtc::scoped_refptr<DtlsCertificate> Create(
+      rtc::scoped_ptr<rtc::SSLIdentity> identity);
+
+  rtc::SSLIdentity* identity() const;
+  double expires() const;
+
+ protected:
+  DtlsCertificate(rtc::SSLIdentity* identity, double expires);
+  ~DtlsCertificate() override;
+
+ private:
+  rtc::scoped_ptr<rtc::SSLIdentity> identity_;
+  double expires_;
+};
 
 }  // namespace webrtc
+
+#endif  // TALK_APP_WEBRTC_DTLSCERTIFICATE_H_