Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/peerconnection.h

 /*
  * libjingle
  * Copyright 2012 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 40 matching lines @@
 // It uses MediaStreamSignaling and WebRtcSession to implement
 // the PeerConnection functionality.
 class PeerConnection : public PeerConnectionInterface,
                        public MediaStreamSignalingObserver,
                        public IceObserver,
                        public rtc::MessageHandler,
                        public sigslot::has_slots<> {
  public:
   explicit PeerConnection(PeerConnectionFactory* factory);
 
+  // This method takes the ownership of |dtls_identity_service|.
   bool Initialize(
-      const PeerConnectionInterface::RTCConfiguration& configuration,
-      const MediaConstraintsInterface* constraints,
-      PortAllocatorFactoryInterface* allocator_factory,
-      rtc::scoped_ptr<DtlsIdentityStoreInterface> dtls_identity_store,
-      PeerConnectionObserver* observer);
+        const PeerConnectionInterface::RTCConfiguration& configuration,
+        const MediaConstraintsInterface* constraints,
+        PortAllocatorFactoryInterface* allocator_factory,
+        rtc::scoped_ptr<DtlsIdentityStoreInterface> dtls_identity_store,
+        PeerConnectionObserver* observer);
+  bool Initialize(
+        const PeerConnectionInterface::RTCConfiguration& configuration,
+        const MediaConstraintsInterface* constraints,
+        PortAllocatorFactoryInterface* allocator_factory,
+        const rtc::scoped_refptr<DtlsCertificate>& certificate,
+        PeerConnectionObserver* observer);
   virtual rtc::scoped_refptr<StreamCollectionInterface> local_streams();
   virtual rtc::scoped_refptr<StreamCollectionInterface> remote_streams();
   virtual bool AddStream(MediaStreamInterface* local_stream);
   virtual void RemoveStream(MediaStreamInterface* local_stream);
 
   virtual rtc::scoped_refptr<DtmfSenderInterface> CreateDtmfSender(
       AudioTrackInterface* track);
 
   virtual rtc::scoped_refptr<DataChannelInterface> CreateDataChannel(
       const std::string& label,
@@ skipping 32 matching lines @@
   virtual bool AddIceCandidate(const IceCandidateInterface* candidate);
 
   virtual void RegisterUMAObserver(UMAObserver* observer);
 
   virtual void Close();
 
  protected:
   virtual ~PeerConnection();
 
  private:
+  bool InitializeCommon(

[Henrik Grunell WebRTC, 2015/08/12 14:46:29]

I think these two can have clearer names. Try describing what they do at a high
level.

[hbos, 2015/08/14 14:09:38]

Done. I merged the second helper function into the first one because those last
steps did not have to be ordered after session_->Initialize.

+      const PeerConnectionInterface::RTCConfiguration& configuration,
+      const MediaConstraintsInterface* constraints,
+      PortAllocatorFactoryInterface* allocator_factory,
+      PeerConnectionObserver* observer);
+  void InitializeSessionAfterInit();
+
   // Implements MessageHandler.
   virtual void OnMessage(rtc::Message* msg);
 
   // Implements MediaStreamSignalingObserver.
   void OnAddRemoteStream(MediaStreamInterface* stream) override;
   void OnRemoveRemoteStream(MediaStreamInterface* stream) override;
   void OnAddDataChannel(DataChannelInterface* data_channel) override;
   void OnAddRemoteAudioTrack(MediaStreamInterface* stream,
                              AudioTrackInterface* audio_track,
                              uint32 ssrc) override;
@@ skipping 58 matching lines @@
   rtc::scoped_ptr<cricket::PortAllocator> port_allocator_;
   rtc::scoped_ptr<WebRtcSession> session_;
   rtc::scoped_ptr<MediaStreamSignaling> mediastream_signaling_;
   rtc::scoped_ptr<MediaStreamHandlerContainer> stream_handler_container_;
   rtc::scoped_ptr<StatsCollector> stats_;
 };
 
 }  // namespace webrtc
 
 #endif  // TALK_APP_WEBRTC_PEERCONNECTION_H_