Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/dtlscertificate.h

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
  *     this list of conditions and the following disclaimer in the documentation
  *     and/or other materials provided with the distribution.
  *  3. The name of the author may not be used to endorse or promote products
  *     derived from this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
  * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "talk/app/webrtc/dtlsidentityservice.h"
+#ifndef TALK_APP_WEBRTC_DTLSCERTIFICATE_H_
+#define TALK_APP_WEBRTC_DTLSCERTIFICATE_H_
 
-#include "talk/app/webrtc/dtlsidentitystore.h"
-#include "webrtc/base/logging.h"
+#include <string>
+
+#include "webrtc/base/refcount.h"
+#include "webrtc/base/scoped_ptr.h"
+#include "webrtc/base/scoped_ref_ptr.h"
+#include "webrtc/base/sslidentity.h"
 
 namespace webrtc {

[hbos, 2015/08/10 15:10:18]

Hmh... should I use the webrtc or rtc namespace for this? SSLIdentity is in rtc.
Not sure what the namespaces imply.

A question along the same lines is whether this belongs here, in
talk/app/webrtc/, or in webrtc/base/ where SSLIdentity is located. I placed it
in talk/app/webrtc and used the webrtc namespace simply because that's where the
dtlsidentitystore & -service was located.

 
-bool DtlsIdentityService::RequestIdentity(
-    const std::string& identity_name,
-    const std::string& common_name,
-    webrtc::DTLSIdentityRequestObserver* observer) {
-  if (identity_name != DtlsIdentityStore::kIdentityName ||
-      common_name != DtlsIdentityStore::kIdentityName) {
-    LOG(LS_WARNING) << "DtlsIdentityService::RequestIdentity called with "
-                    << "unsupported params, identity_name=" << identity_name
-                    << ", common_name=" << common_name;
-    return false;
-  }
-  store_->RequestIdentity(observer);
-  return true;
-}
+class DtlsCertificate : public rtc::RefCountInterface {
+ public:
+  static rtc::scoped_refptr<DtlsCertificate> Create(
+      rtc::scoped_ptr<rtc::SSLIdentity> identity);
+
+  rtc::SSLIdentity* identity() const;
+  double expires() const;
+
+ protected:
+  DtlsCertificate(rtc::SSLIdentity* identity, double expires);
+  ~DtlsCertificate() override;
+
+ private:
+  rtc::scoped_ptr<rtc::SSLIdentity> identity_;
+  double expires_;
+};
 
 }  // namespace webrtc
+
+#endif  // TALK_APP_WEBRTC_DTLSCERTIFICATE_H_