Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/test/fakedtlsidentityservice.h

 /*
  * libjingle
  * Copyright 2013 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 10 matching lines @@
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef TALK_APP_WEBRTC_TEST_FAKEDTLSIDENTITYSERVICE_H_
 #define TALK_APP_WEBRTC_TEST_FAKEDTLSIDENTITYSERVICE_H_
 
+#include "talk/app/webrtc/dtlscertificate.h"
+#include "talk/app/webrtc/dtlsidentitystore.h"
 #include "talk/app/webrtc/peerconnectioninterface.h"
 
 static const char kRSA_PRIVATE_KEY_PEM[] =
     "-----BEGIN RSA PRIVATE KEY-----\n"
     "MIICdwIBADANBgkqhkiG9w0BAQEFAASCAmEwggJdAgEAAoGBAMYRkbhmI7kVA/rM\n"
     "czsZ+6JDhDvnkF+vn6yCAGuRPV03zuRqZtDy4N4to7PZu9PjqrRl7nDMXrG3YG9y\n"
     "rlIAZ72KjcKKFAJxQyAKLCIdawKRyp8RdK3LEySWEZb0AV58IadqPZDTNHHRX8dz\n"
     "5aTSMsbbkZ+C/OzTnbiMqLL/vg6jAgMBAAECgYAvgOs4FJcgvp+TuREx7YtiYVsH\n"
     "mwQPTum2z/8VzWGwR8BBHBvIpVe1MbD/Y4seyI2aco/7UaisatSgJhsU46/9Y4fq\n"
     "2TwXH9QANf4at4d9n/R6rzwpAJOpgwZgKvdQjkfrKTtgLV+/dawvpxUYkRH4JZM1\n"
@@ skipping 47 matching lines @@
                                DTLSIdentityRequestObserver* observer) {
     MessageData* msg = new MessageData(Request(common_name, observer));
     if (should_fail_) {
       rtc::Thread::Current()->Post(this, MSG_FAILURE, msg);
     } else {
       rtc::Thread::Current()->Post(this, MSG_SUCCESS, msg);
     }
     return true;
   }
 
+  static rtc::scoped_refptr<webrtc::DtlsCertificate> GenerateCertificate() {
+    std::string cert;
+    std::string key;
+    GenerateIdentity(webrtc::DtlsIdentityStore::kIdentityName, &cert, &key);
+
+    std::string pem_cert = rtc::SSLIdentity::DerToPem(
+        rtc::kPemTypeCertificate,
+        reinterpret_cast<const unsigned char*>(cert.data()),
+        cert.length());
+    std::string pem_key = rtc::SSLIdentity::DerToPem(
+        rtc::kPemTypeRsaPrivateKey,
+        reinterpret_cast<const unsigned char*>(key.data()),
+        key.length());
+    rtc::scoped_ptr<rtc::SSLIdentity> identity(
+        rtc::SSLIdentity::FromPEMStrings(pem_key, pem_cert));
+
+    return webrtc::DtlsCertificate::Create(identity.Pass());
+  }
+
  private:
   enum {
     MSG_SUCCESS,
     MSG_FAILURE,
   };
 
   // rtc::MessageHandler implementation.
   void OnMessage(rtc::Message* msg) {
     FakeIdentityService::MessageData* message_data =
         static_cast<FakeIdentityService::MessageData*>(msg->pdata);
     DTLSIdentityRequestObserver* observer = message_data->data().observer.get();
     switch (msg->message_id) {
       case MSG_SUCCESS: {
         std::string cert, key;
         GenerateIdentity(message_data->data().common_name, &cert, &key);
         observer->OnSuccess(cert, key);
         break;
       }
       case MSG_FAILURE:
         observer->OnFailure(0);
         break;
     }
     delete message_data;
   }
 
-  void GenerateIdentity(
+  static void GenerateIdentity(

[Henrik Grunell WebRTC, 2015/08/05 07:41:20]

Make this an ordinary function in the implementation file instead of static.

[hbos, 2015/08/06 12:11:34]

We talked about this and decided it didn't matter (right?). Keeping it static
unless there is a reason to change it.

[Henrik Grunell WebRTC, 2015/08/06 14:06:52]

Acknowledged.

       const std::string& common_name,
       std::string* der_cert,
       std::string* der_key) {
     rtc::SSLIdentity::PemToDer("CERTIFICATE", kCERT_PEM, der_cert);
     rtc::SSLIdentity::PemToDer("RSA PRIVATE KEY",
                                      kRSA_PRIVATE_KEY_PEM,
                                      der_key);
   }
 
   bool should_fail_;
 };
 
 #endif  // TALK_APP_WEBRTC_TEST_FAKEDTLSIDENTITYSERVICE_H_