Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: talk/app/webrtc/dtlscertificate.cc

Issue 1269843005: Added DtlsCertificate, a ref counted object owning an SSLIdentity (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: webrtcsession_unittest cleanup Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2015 Google Inc. 3 * Copyright 2015 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
11 * this list of conditions and the following disclaimer in the documentation 11 * this list of conditions and the following disclaimer in the documentation
12 * and/or other materials provided with the distribution. 12 * and/or other materials provided with the distribution.
13 * 3. The name of the author may not be used to endorse or promote products 13 * 3. The name of the author may not be used to endorse or promote products
14 * derived from this software without specific prior written permission. 14 * derived from this software without specific prior written permission.
15 * 15 *
16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED 16 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF 17 * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO 18 * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 19 * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 20 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; 21 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, 22 * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR 23 * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF 24 * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 25 * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26 */ 26 */
27 27
28 #include "talk/app/webrtc/dtlsidentityservice.h" 28 #include "talk/app/webrtc/dtlscertificate.h"
29 29
30 #include "talk/app/webrtc/dtlsidentitystore.h" 30 #include "webrtc/base/checks.h"
31 #include "webrtc/base/logging.h"
32 31
33 namespace webrtc { 32 namespace webrtc {
34 33
35 bool DtlsIdentityService::RequestIdentity( 34 rtc::scoped_refptr<DtlsCertificate> DtlsCertificate::Create(
36 const std::string& identity_name, 35 rtc::scoped_ptr<rtc::SSLIdentity> identity) {
37 const std::string& common_name, 36 // TODO(hbos): |expires| should be specified (what is the right type for
38 webrtc::DTLSIdentityRequestObserver* observer) { 37 // date?), and maybe tied to the identity generation?
39 if (identity_name != DtlsIdentityStore::kIdentityName || 38 return new rtc::RefCountedObject<DtlsCertificate>(identity.release(), 0.0);
hbos 2015/08/04 12:50:21 In blink it looked like double was used for dates
40 common_name != DtlsIdentityStore::kIdentityName) { 39 }
41 LOG(LS_WARNING) << "DtlsIdentityService::RequestIdentity called with " 40
42 << "unsupported params, identity_name=" << identity_name 41 DtlsCertificate::DtlsCertificate(rtc::SSLIdentity* identity, double expires)
43 << ", common_name=" << common_name; 42 : identity_(identity), expires_(expires) {
44 return false; 43 DCHECK(identity_.get());
45 } 44 }
46 store_->RequestIdentity(observer); 45
47 return true; 46 rtc::SSLIdentity* DtlsCertificate::identity() const {
47 return identity_.get();
48 }
49
50 double DtlsCertificate::expires() const {
51 return expires_;
48 } 52 }
49 53
50 } // namespace webrtc 54 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698