|
|
Created:
5 years, 4 months ago by sprang_webrtc Modified:
5 years, 4 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix race condition in EndToEndTest.AssignsTransportSequenceNumbers
Don't verify increasing sequence numbers after test complesion as this
can be racy with regards to test shutting down send transports.
BUG=4894
R=stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/8d62971611bac3e19d4489427a4b8346ad1e4ca8
Patch Set 1 #
Created: 5 years, 4 months ago
Messages
Total messages: 16 (7 generated)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743004/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743004/1
sprang@webrtc.org changed reviewers: + stefan@webrtc.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 8d62971611bac3e19d4489427a4b8346ad1e4ca8 (presubmit successful). |