Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1269743004: Fix race condition in EndToEndTest.AssignsTransportSequenceNumbers (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix race condition in EndToEndTest.AssignsTransportSequenceNumbers Don't verify increasing sequence numbers after test complesion as this can be racy with regards to test shutting down send transports. BUG=4894 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/8d62971611bac3e19d4489427a4b8346ad1e4ca8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M webrtc/video/end_to_end_tests.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743004/1
5 years, 4 months ago (2015-08-04 08:36:59 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-04 08:37:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743004/1
5 years, 4 months ago (2015-08-04 08:37:28 UTC) #6
sprang_webrtc
5 years, 4 months ago (2015-08-04 08:37:53 UTC) #8
stefan-webrtc
lgtm
5 years, 4 months ago (2015-08-04 08:44:59 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-04 10:37:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269743004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269743004/1
5 years, 4 months ago (2015-08-04 11:00:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-04 13:00:58 UTC) #15
sprang_webrtc
5 years, 4 months ago (2015-08-04 14:24:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d62971611bac3e19d4489427a4b8346ad1e4ca8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698