Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1269563002: Added protection for GetCapabilities() failure. (Closed)

Created:
5 years, 4 months ago by Dani Kirov
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added protection for GetCapabilities() failure. On GetCapabilities() failure, caps.cDestinations is left uninitialized. Without a protection the following code runs in a random loop in the worst case up to 0xFFFFFFFF times. for (destId = 0; destId < caps.cDestinations; destId++) { GetDestinationLineInfo(mixId, destId, destLine); BUG=webrtc:4882 Committed: https://crrev.com/a12ba5502c09b56aa6f8e101e6af7f2d12440663 Cr-Commit-Position: refs/heads/master@{#9663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/modules/audio_device/win/audio_mixer_manager_win.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dani Kirov
5 years, 4 months ago (2015-07-29 17:30:18 UTC) #1
braveyao1
Please have a look when you are available.
5 years, 4 months ago (2015-07-30 06:17:06 UTC) #3
henrika_webrtc
LGTM
5 years, 4 months ago (2015-07-30 12:01:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1269563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1269563002/1
5 years, 4 months ago (2015-07-31 03:10:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 03:51:44 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 03:51:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a12ba5502c09b56aa6f8e101e6af7f2d12440663
Cr-Commit-Position: refs/heads/master@{#9663}

Powered by Google App Engine
This is Rietveld 408576698