DtlsIdentityStoreInterface added.

DtlsIdentityStoreInterface added.
New PeerConnectionFactoryInterface::CreatePeerConnection taking both service and store added (old CreatePC signature still exists).

This is CL is part of an effort to land https://codereview.webrtc.org/1176383004 without breaking Chromium.
See bug for more information.

BUG=webrtc:4899
R=tommi@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/5b4ce3391d60229342963ef524b7c1e359e5bfc4

[hbos, 2015-08-05 09:31:05]

hbos@webrtc.org changed reviewers:
+ tommi@webrtc.org

[hbos, 2015-08-05 09:49:23]

PTAL tommi and look at the referenced bug for how I plan to land this without
breaking stuff (maybe there is an easier way?).

[tommi, 2015-08-05 10:20:05]

https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h
File webrtc/base/sslidentity.h (right):

https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h#new...
webrtc/base/sslidentity.h:25: enum KeyType { KT_RSA, KT_ECDSA, KT_LAST,
KT_DEFAULT = KT_RSA };
DtlsKeyType? (since this is in the rtc namespace)

This doesn't appear to be used in this file though. Is this the right place for
this enum?

[hbos, 2015-08-05 11:41:15]

PTAL again tommi :)

https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h
File webrtc/base/sslidentity.h (right):

https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h#new...
webrtc/base/sslidentity.h:25: enum KeyType { KT_RSA, KT_ECDSA, KT_LAST,
KT_DEFAULT = KT_RSA };
On 2015/08/05 10:20:05, tommi (webrtc) wrote:
> DtlsKeyType? (since this is in the rtc namespace)
> 
> This doesn't appear to be used in this file though. Is this the right place
for
> this enum?

Yes. I placed it here because this is the file torbjorng places it in (in his CL
https://codereview.webrtc.org/1189583002). When his CL lands it will be used
here a lot.
Renaming it has bigger implications for his CL than mine, so if that's something
we want to do I think that should start with him.
Leaving it as-is (if its renamed in torbjorng's CL we can always update my
references to it).

https://codereview.webrtc.org/1268363002/diff/20001/talk/app/webrtc/peerconne...
File talk/app/webrtc/peerconnectioninterface.h (right):

https://codereview.webrtc.org/1268363002/diff/20001/talk/app/webrtc/peerconne...
talk/app/webrtc/peerconnectioninterface.h:99: class DTLSIdentityRequestObserver;
Oops, unnecessary, will remove.

[tommi, 2015-08-05 11:46:37]

lgtm - before commit it would be good to add a link to the other review where
some of this has already been looked over.

[hbos, 2015-08-05 14:55:54]

Committed patchset #3 (id:40001) manually as
5b4ce3391d60229342963ef524b7c1e359e5bfc4 (presubmit successful).