Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1268363002: DtlsIdentityStoreInterface added. (Closed)

Created:
3 years, 10 months ago by hbos
Modified:
3 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

DtlsIdentityStoreInterface added. New PeerConnectionFactoryInterface::CreatePeerConnection taking both service and store added (old CreatePC signature still exists). This is CL is part of an effort to land https://codereview.webrtc.org/1176383004 without breaking Chromium. See bug for more information. BUG=webrtc:4899 R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/5b4ce3391d60229342963ef524b7c1e359e5bfc4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Making trybots compile (hopefully) #

Total comments: 1

Patch Set 3 : Merge with master, remove unnecessary forw decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -18 lines) Patch
M talk/app/webrtc/dtlsidentitystore.h View 1 1 chunk +49 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 2 3 chunks +15 lines, -16 lines 0 comments Download
M webrtc/base/sslidentity.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hbos
PTAL tommi and look at the referenced bug for how I plan to land this ...
3 years, 10 months ago (2015-08-05 09:49:23 UTC) #2
tommi
https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h File webrtc/base/sslidentity.h (right): https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h#newcode25 webrtc/base/sslidentity.h:25: enum KeyType { KT_RSA, KT_ECDSA, KT_LAST, KT_DEFAULT = KT_RSA ...
3 years, 10 months ago (2015-08-05 10:20:05 UTC) #3
hbos
PTAL again tommi :) https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h File webrtc/base/sslidentity.h (right): https://codereview.webrtc.org/1268363002/diff/1/webrtc/base/sslidentity.h#newcode25 webrtc/base/sslidentity.h:25: enum KeyType { KT_RSA, KT_ECDSA, ...
3 years, 10 months ago (2015-08-05 11:41:15 UTC) #4
tommi
lgtm - before commit it would be good to add a link to the other ...
3 years, 10 months ago (2015-08-05 11:46:37 UTC) #5
hbos
3 years, 10 months ago (2015-08-05 14:55:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5b4ce3391d60229342963ef524b7c1e359e5bfc4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698