Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1268333005: AndroidVideoCapturer: Return frames that have been dropped (Closed)

Created:
5 years, 4 months ago by magjed_webrtc
Modified:
5 years, 4 months ago
Reviewers:
AlexG, åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AndroidVideoCapturer: Return frames that have been dropped Currently, we only return frames if CreateAliasedFrame() is called, which is not the case for dropped frames. Committed: https://crrev.com/fcf8ece6ba1d170fc70a457d93b35eccb3074022 Cr-Commit-Position: refs/heads/master@{#9683}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M talk/app/webrtc/androidvideocapturer.cc View 6 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268333005/1
5 years, 4 months ago (2015-08-05 14:34:55 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/1648)
5 years, 4 months ago (2015-08-05 15:09:10 UTC) #5
magjed_webrtc
Please take a look.
5 years, 4 months ago (2015-08-05 15:30:03 UTC) #7
AlexG
lgtm
5 years, 4 months ago (2015-08-05 18:30:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268333005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268333005/20001
5 years, 4 months ago (2015-08-06 09:44:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-06 11:00:20 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 11:00:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcf8ece6ba1d170fc70a457d93b35eccb3074022
Cr-Commit-Position: refs/heads/master@{#9683}

Powered by Google App Engine
This is Rietveld 408576698