webrtc/voice_engine/include/voe_codec.h - Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/include/voe_codec.h

Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added comment regarding pointer lifetime on the VoECodec sub-API. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/main/interface/audio_coding_module.h ('K') | « webrtc/voice_engine/channel_manager.cc ('k') | webrtc/voice_engine/shared_data.cc » ('j') | webrtc/voice_engine/voe_base_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/voice_engine/include/voe_codec.h

diff --git a/webrtc/voice_engine/include/voe_codec.h b/webrtc/voice_engine/include/voe_codec.h

index 5d94ac27365a91fa3df47901f28ad66422ab7b4f..6c4fb38a2faf4fa18093ba0bbca2cd85853d3c63 100644

--- a/webrtc/voice_engine/include/voe_codec.h

+++ b/webrtc/voice_engine/include/voe_codec.h

@@ -35,6 +35,7 @@

namespace webrtc {

+class RtcEventLog;

class VoiceEngine;

class WEBRTC_DLLEXPORT VoECodec {

@@ -131,6 +132,10 @@ class WEBRTC_DLLEXPORT VoECodec {

// success, and -1 if failed.

virtual int SetOpusDtx(int channel, bool enable_dtx) = 0;

+ // Get a pointer to the event logging object associated with this Voice

+ // Engine. This pointer will remain valid until VoiceEngine is destroyed.

+ virtual RtcEventLog* GetEventLog() = 0;

protected:

VoECodec() {}

virtual ~VoECodec() {}