webrtc/modules/audio_coding/BUILD.gn - Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/BUILD.gn

Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added comment regarding pointer lifetime on the VoECodec sub-API. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/media/webrtc/fakewebrtcvoiceengine.h ('k') | webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h » ('j') | webrtc/modules/audio_coding/main/interface/audio_coding_module.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/BUILD.gn

diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn

index 8a27900edf8bf05db90d64a262a3885f177bcd62..e4ceddb3e0469d7b896a1189d71e0e845c4176a0 100644

--- a/webrtc/modules/audio_coding/BUILD.gn

+++ b/webrtc/modules/audio_coding/BUILD.gn

@@ -58,6 +58,12 @@ source_set("audio_coding") {

]

}

+ if (is_clang) {

+ # Suppress warnings from Chrome's Clang plugins.

+ # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.

+ configs -= [ "//build/config/clang:find_bad_constructs" ]

+ }

deps = [

":cng",

":g711",

@@ -68,6 +74,7 @@ source_set("audio_coding") {

":neteq",

":pcm16b",

":red",

+ "../..:rtc_event_log",

"../..:webrtc_common",

"../../common_audio",

"../../system_wrappers",