webrtc/voice_engine/channel.h - Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel.h

Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: All SetEventLog() functions have been removed, the pointer is now propagated through the constructo… Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/voice_engine/channel.h

diff --git a/webrtc/voice_engine/channel.h b/webrtc/voice_engine/channel.h

index 398087eefb481a0cd96624b6b086c3d9c0acbe58..1eae150ee0681ebcdacbde7277997cd192ad0361 100644

--- a/webrtc/voice_engine/channel.h

+++ b/webrtc/voice_engine/channel.h

@@ -51,6 +51,7 @@ class FileWrapper;

class ProcessThread;

class ReceiveStatistics;

class RemoteNtpTimeEstimator;

+class RtcEventLog;

class RTPPayloadRegistry;

class RtpReceiver;

class RTPReceiverAudio;

@@ -170,8 +171,12 @@ public:

static int32_t CreateChannel(Channel*& channel,

int32_t channelId,

uint32_t instanceId,

+ RtcEventLog* const event_log,

Henrik Grunell WebRTC 2015/08/12 15:29:53 Remove const.

const Config& config);

- Channel(int32_t channelId, uint32_t instanceId, const Config& config);

+ Channel(int32_t channelId,

+ uint32_t instanceId,

+ RtcEventLog* const event_log,

Henrik Grunell WebRTC 2015/08/12 15:29:53 Same here.

+ const Config& config);

int32_t Init();

int32_t SetEngineInformation(

Statistics& engineStatistics,

« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/voice_engine/BUILD.gn ('k') | webrtc/voice_engine/channel.cc » ('j') | webrtc/voice_engine/channel.cc » ('J')