Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: webrtc/voice_engine/include/voe_codec.h

Issue 1267683002: Hooked up RtcEventLog. It lives in Voice Engine and pointers are propagated to ACM and Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Processed more comments from Henrik. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/include/voe_codec.h
diff --git a/webrtc/voice_engine/include/voe_codec.h b/webrtc/voice_engine/include/voe_codec.h
index 5d94ac27365a91fa3df47901f28ad66422ab7b4f..a0703618e654a61c5dc378ccdf26af607ecf2a67 100644
--- a/webrtc/voice_engine/include/voe_codec.h
+++ b/webrtc/voice_engine/include/voe_codec.h
@@ -35,6 +35,7 @@
namespace webrtc {
+class RtcEventLog;
class VoiceEngine;
class WEBRTC_DLLEXPORT VoECodec {
@@ -131,6 +132,10 @@ class WEBRTC_DLLEXPORT VoECodec {
// success, and -1 if failed.
virtual int SetOpusDtx(int channel, bool enable_dtx) = 0;
+ // Get a pointer to the event logging object associated with this Voice
Henrik Grunell WebRTC 2015/08/05 09:44:35 Is the event logging object related to codec(s) on
ivoc 2015/08/06 10:57:51 I was not entirely sure which of the sub-APIs is m
Henrik Grunell WebRTC 2015/08/06 15:30:45 Right, it's given to |audio_coding_| in the channe
+ // Engine.
+ virtual RtcEventLog* GetEventLog() = 0;
Henrik Grunell WebRTC 2015/08/05 09:44:35 Instead of getting a pointer and operate directly
ivoc 2015/08/06 10:57:52 We need more functionality than just enable/disabl
Henrik Grunell WebRTC 2015/08/06 15:30:45 OK. In that case I'd prefer the VoE user to have o
Henrik Grunell WebRTC 2015/08/07 11:30:03 We talked offline and since (1) the path in libjin
+
protected:
VoECodec() {}
virtual ~VoECodec() {}

Powered by Google App Engine
This is Rietveld 408576698